Skip to content

fix(ci): snapshot parity test #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanabi1224 merged 2 commits into from
Oct 13, 2025
Merged

fix(ci): snapshot parity test #6159

hanabi1224 merged 2 commits into from
Oct 13, 2025

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 13, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • add --format v1 to forest-cli snapshot export

Reference issue to close (if applicable)

Closes #6154

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Tests
    • Updated snapshot export in the CLI test workflow to explicitly use format v1.
    • No changes to the surrounding test flow (import, wait, sync, shutdown).
    • No user-facing behavior changes outside the test environment.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025 •
edited
Loading

Walkthrough

Adds explicit --format v1 to the forest-cli snapshot export command in the snapshot parity test Docker workflow. No other steps or control flow are changed.

Changes

Cohort / File(s) Summary
Snapshot parity test workflow
scripts/tests/snapshot_parity/docker-compose.yml		 Update snapshot export command to include --format v1; other commands (import, wait, sync, kill) unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • elmattic
  • ADobrodey

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely indicates the primary change, namely fixing the snapshot parity test in CI, and it is fully related to the changeset without extraneous detail or vagueness.
Linked Issues Check ✅ Passed The pull request adds the missing --format v1 flag to the snapshot export command to resolve the failing parity test as described in issue #6154, directly addressing the primary coding requirement without altering unrelated functionality.
Out of Scope Changes Check ✅ Passed The sole change modifies the snapshot export command in the snapshot parity test workflow without introducing unrelated edits, so all modifications are directly related to fixing the CI test as scoped in issue #6154.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/fix-snap-parity-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 13, 2025 09:34
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 13, 2025 09:34
@hanabi1224 hanabi1224 requested review from elmattic and sudo-shashank and removed request for a team October 13, 2025 09:34
@hanabi1224 hanabi1224 enabled auto-merge October 13, 2025 09:34
coderabbitai[bot]
coderabbitai bot reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
scripts/tests/snapshot_parity/docker-compose.yml (1)

51-51: Good fix: forcing CARv1 aligns with Lotus export and should stabilize parity.

This matches Lotus’s CARv1 output and likely resolves the mismatch. Please confirm the Forest image in CI supports the --format flag to avoid runtime failures. Optionally, you can drop the “Index size” grep in compare since CARv1 won’t include it, though it’s harmless to keep.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5685be4 and 8375be8.

📒 Files selected for processing (1)
  • scripts/tests/snapshot_parity/docker-compose.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: tests-release
  • GitHub Check: tests
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build Ubuntu
  • GitHub Check: All lint checks

@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit 150ac09 Oct 13, 2025
41 checks passed
@hanabi1224 hanabi1224 deleted the hm/fix-snap-parity-test branch October 13, 2025 13:53
@coderabbitai coderabbitai bot mentioned this pull request Oct 17, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@sudo-shashank sudo-shashank sudo-shashank approved these changes

+1 more reviewer

@elmattic elmattic elmattic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[automated] Snapshot parity test failure

4 participants

@hanabi1224 @elmattic @sudo-shashank