Skip to content

chore: upgrade rust toolchain to 1.90 #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanabi1224 merged 1 commit into from
Oct 8, 2025
Merged

chore: upgrade rust toolchain to 1.90 #6139

hanabi1224 merged 1 commit into from
Oct 8, 2025

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 8, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • upgrade rust toolchain to 1.90
  • fix new clippy warnings

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • New Features
    • No user-facing features added.
  • Refactor
    • Streamlined and reduced public API surface by removing unused/deprecated types and re-exports.
    • Consolidated serialization helpers and simplified internal readers.
    • Standardized numeric checks for periodic logging and progress reporting.
  • Tests
    • Cleaned up test-only structures and imports.
  • Chores
    • Upgraded Rust toolchain to 1.90.0.

No functional changes expected for end-users.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 8, 2025 02:56
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 8, 2025 02:56
@hanabi1224 hanabi1224 requested review from akaladarshi and elmattic and removed request for a team October 8, 2025 02:56
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025 •
edited
Loading

Walkthrough

Updates Rust toolchain to 1.90.0. Removes several public types and re-exports across auth, beacon tests, chain store, libp2p, lotus_json, RPC types, and ETH types. Adjusts some logging/modulo checks to use is_multiple_of. Adds #[allow(dead_code)] in selector. Minor signature tweak in CAR reader.

Changes

Cohort / File(s) Summary of Changes
Toolchain bump
rust-toolchain.toml		 Channel updated from "1.89.0" to "1.90.0"; components unchanged.
Auth API surface
src/auth/mod.rs		 Removed public Error enum (variants: MethodParam, InvalidPermissions, NoAuthHeader, Other). No replacement type added.
Beacon test type removal
src/beacon/tests/drand.rs		 Removed public BeaconEntryJson struct and related serde imports; tests otherwise unchanged.
Chain headchange JSON removal
src/chain/store/chain_store.rs		 Removed mod headchange_json, public HeadChangeJson enum, and From<HeadChange> impl. Core HeadChange unaffected.
DB CAR updates
src/db/car/forest/index/hash.rs, src/db/car/plain.rs		 Replaced (a % b == 0) with a.is_multiple_of(b) in div_ceil. Removed public CompressedBlockDataLocation; adjusted read_block_data_location_and_skip to accept impl Read + Seek directly (not a tuple).
Selector annotations
src/ipld/selector/mod.rs		 Added #[allow(dead_code)] to several types; no public signatures changed.
Libp2p re-export removal
src/libp2p/mod.rs		 Removed pub use cid::multihash::Multihash;.
Lotus JSON miner params
src/lotus_json/actors/params/miner_params.rs		 Removed public ExtendSectorExpirationParams type.
ETH subscription types
src/rpc/methods/eth/types.rs		 Removed public SubscriptionID type and lotus_json helper; associated derives removed.
RPC types consolidation
src/rpc/types/mod.rs		 Removed public PeerID, ApiState, ApiDecodedParams and related lotus_json helpers; removed libp2p::Multihash usage.
Progress/logging predicate updates
src/rpc/methods/state.rs, src/state_migration/common/state_migration.rs		 Replaced modulo-based periodic checks with is_multiple_of(...); behavior equivalent.

Sequence Diagram(s)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

rust

Suggested reviewers

  • LesnyRumcajs
  • sudo-shashank
  • elmattic

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely and accurately captures the primary change—upgrading the Rust toolchain to version 1.90—as stated in the PR objectives, without unnecessary detail or ambiguity.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/rust-1.90

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit 7942fad Oct 8, 2025
45 checks passed
@hanabi1224 hanabi1224 deleted the hm/rust-1.90 branch October 8, 2025 09:16
@coderabbitai coderabbitai bot mentioned this pull request Nov 4, 2025
Merged
4 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akaladarshi akaladarshi akaladarshi approved these changes

@sudo-shashank sudo-shashank sudo-shashank approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hanabi1224 @akaladarshi @sudo-shashank