Skip to content

fix(ci): cleanup snapshot export checks #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanabi1224 merged 1 commit into from
Oct 8, 2025
Merged

fix(ci): cleanup snapshot export checks #6138

hanabi1224 merged 1 commit into from
Oct 8, 2025

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 8, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Since v2 snasphot on calibnet are now hosted, we don't need the hacky merge approach anymore.

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores

    • Renamed CI workflow jobs and labels for clarity, standardizing V1/V2 snapshot export checks.
    • Updated integration status dependencies to reference the new V1 job name.

  • Tests

    • Removed obsolete F3 snapshot export validation scripts and related test harness logic.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025 •
edited
Loading

Walkthrough

Renames CI jobs and steps in .github/workflows/forest.yml for v1/v2 snapshot export checks and updates integration job dependencies. Removes the F3 snapshot export test script. Deletes F3-related functions and references from the test harness.

Changes

Cohort / File(s) Summary
CI workflow updates
.github/workflows/forest.yml		 Renamed v1 job id and labels; adjusted script invocations to use calibnet_export_check.sh v1/v2; updated integration job dependency to calibnet-export-check-v1.
Remove F3 export test script
scripts/tests/calibnet_export_f3_check.sh		 Deleted entire script that performed F3-based snapshot export, validation, and checksum checks.
Test harness cleanup
scripts/tests/harness.sh		 Removed F3-specific functions: forest_download_and_import_snapshot_with_f3, forest_init_with_f3; eliminated F3 workflow references.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant GH as GitHub Actions
  participant V1 as calibnet-export-check-v1
  participant V2 as calibnet-export-check-v2
  participant INT as integration-tests-status

  Dev->>GH: Push / PR
  GH->>V1: Run "V1 snapshot export checks"
  GH->>V2: Run "V2 snapshot export checks"
  par Snapshot checks
    V1-->>GH: Status
    V2-->>GH: Status
  end
  GH->>INT: Aggregate status (needs: V1, V2)
  INT-->>Dev: Result
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
  • sudo-shashank

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely states the main change of cleaning up snapshot export checks in the CI pipeline, matching the renaming and removal of related workflow jobs and scripts in the pull request. It is a single sentence without extraneous details, making it easy for teammates to understand the primary focus at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/cleanup-ci-snap-export-checks
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21390d7 and 28b34cc.

📒 Files selected for processing (3)
  • .github/workflows/forest.yml (4 hunks)
  • scripts/tests/calibnet_export_f3_check.sh (0 hunks)
  • scripts/tests/harness.sh (0 hunks)
💤 Files with no reviewable changes (2)
  • scripts/tests/harness.sh
  • scripts/tests/calibnet_export_f3_check.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: All lint checks
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build MacOS
  • GitHub Check: Build Ubuntu

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 8, 2025 02:33
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 8, 2025 02:33
@hanabi1224 hanabi1224 requested review from akaladarshi and elmattic and removed request for a team October 8, 2025 02:33
@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 8, 2025
Merged via the queue into main with commit fd911e4 Oct 8, 2025
68 of 69 checks passed
@hanabi1224 hanabi1224 deleted the hm/cleanup-ci-snap-export-checks branch October 8, 2025 08:17
@coderabbitai coderabbitai bot mentioned this pull request Oct 17, 2025
Merged
4 tasks
This was referenced Oct 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akaladarshi akaladarshi akaladarshi approved these changes

+1 more reviewer

@elmattic elmattic elmattic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hanabi1224 @elmattic @akaladarshi