Skip to content

fix: remove flaky beacon entry size test #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hanabi1224 merged 1 commit into from
Sep 17, 2025
Merged

fix: remove flaky beacon entry size test #6092

hanabi1224 merged 1 commit into from
Sep 17, 2025

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Sep 17, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Tests
    • Removed memory profiling tests that used dhat/get-size2, reducing test flakiness and build overhead.
  • Chores
    • Dropped the dhat dependency at the workspace level.
    • Removed dhat and get-size2 from interop-tests development dependencies to streamline builds and reduce the dependency surface.
    • General cleanup of dev tooling to simplify maintenance with no impact on runtime behavior or public APIs.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner September 17, 2025 08:18
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team September 17, 2025 08:18
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2025 •
edited
Loading

Walkthrough

Removed the workspace-level dhat dependency, dropped dhat and get-size2 from interop-tests dev-dependencies, and deleted a dhat-based memory-size test for BeaconEntry.

Changes

Cohort / File(s) Summary
Workspace deps cleanup
Cargo.toml		 Removed dhat from [workspace.dependencies].
Interop tests dev-deps cleanup
interop-tests/Cargo.toml		 Removed dhat = { workspace = true } and get-size2 = { workspace = true } from [dev-dependencies].
Test removal
interop-tests/tests/dhat_get_size_beacon_entry.rs		 Deleted dhat-based BeaconEntry heap-size test and global allocator usage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • akaladarshi
  • elmattic

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix: remove flaky beacon entry size test" directly and concisely summarizes the primary change (removal of a flaky beacon-entry size test) and matches the diffs that remove the dhat-based test and related dev-dependencies, so a reviewer can quickly understand the main intent. It is specific, short, and relevant for history scanning.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rm-flaky-beacon-dhat-tests
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 940224f and 06851b8.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Cargo.toml (0 hunks)
  • interop-tests/Cargo.toml (0 hunks)
  • interop-tests/tests/dhat_get_size_beacon_entry.rs (0 hunks)
💤 Files with no reviewable changes (3)
  • interop-tests/tests/dhat_get_size_beacon_entry.rs
  • Cargo.toml
  • interop-tests/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Build MacOS
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build Ubuntu
  • GitHub Check: All lint checks
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: tests-release
  • GitHub Check: tests

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs force-pushed the rm-flaky-beacon-dhat-tests branch from 703227b to 06851b8 Compare September 17, 2025 08:19
@hanabi1224 hanabi1224 added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit 2b65a82 Sep 17, 2025
39 checks passed
@hanabi1224 hanabi1224 deleted the rm-flaky-beacon-dhat-tests branch September 17, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@akaladarshi akaladarshi akaladarshi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LesnyRumcajs @hanabi1224 @akaladarshi