-
Notifications
You must be signed in to change notification settings - Fork 182
chore(release): prepare v0.30.0 #6052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the project version to 0.30.0 in Cargo.toml and revises CHANGELOG.md to document the Forest v0.30.0 "Eärendil" release and add unreleased placeholders. No code or API changes are included. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
CHANGELOG.md (3)
40-41: Either add a “Breaking” section or soften the wording.
The paragraph states “includes a few breaking changes,” but there’s no “### Breaking” section below. Add one (listing the CLI removals) or drop “breaking” from the paragraph.Mandatory release for calibration network node operators. It includes the NV27 _Golden Week_ network upgrade at epoch `3_007_294` which corresponds to `Wed 10 Sep 23:00:00 UTC 2025`. This release also includes a few breaking changes (removal of unused commands) and minor fixes. +### Breaking + +- [#6010](https://github.com/ChainSafe/forest/pull/6010) Removing `forest-cli send` is a breaking CLI change (use `forest-wallet send`). +- [#6014](https://github.com/ChainSafe/forest/pull/6014) Removing `--unordered` and `unordered-graph-traversal` flags is breaking for scripts relying on them.
44-44: Minor wording polish.
“More strict” → “Stricter”.-- [#6006](https://github.com/ChainSafe/forest/issues/6006) More strict checks for the address arguments in the `forest-cli` subcommands. +- [#6006](https://github.com/ChainSafe/forest/issues/6006) Stricter checks for address arguments in `forest-cli` subcommands.
46-49: Reduce duplicate bullets (optional).
Both bullets reference the same issue; combine them for brevity.-- [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets. -- [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025). +- [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets and calibration (calibration upgrade epoch `3_007_294`, Wed 10 Sep 23:00:00 UTC 2025).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: cargo-publish-dry-run
- GitHub Check: Build Ubuntu
- GitHub Check: Build MacOS
- GitHub Check: All lint checks
- GitHub Check: tests-release
- GitHub Check: tests
🔇 Additional comments (3)
Cargo.toml (2)
3-3: Version bump looks good.
No other manifest changes detected.
3-3: Version bump verified Manifest files are all updated (root Cargo.toml at 0.30.0, interop-tests at 0.1.0) and no “0.29.0” occurrences remain.CHANGELOG.md (1)
40-49: Epoch ↔ UTC mapping confirmed. Epoch 3,007,294 corresponds to 2025-09-10T23:00:00Z (UTC) per the Filecoin status page [1] and lotus v1.34.0 RC notes [2].
| - [#6006](https://github.com/ChainSafe/forest/issues/6006) More strict checks for the address arguments in the `forest-cli` subcommands. | ||
|
|
||
| - [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets. | ||
|
|
||
| - [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025). | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Fix mismatched issue numbers in links.
The visible issue number is “#5897” but the URL points to “.../issues/5987”. Align them.
-- [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets.
-- [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025).
+# Verify and pick the correct reference (labels here assume 5987 is correct):
+- [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets.
+- [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025).🏁 Script executed:
#!/bin/bash
# Fetch titles for ChainSafe/forest issues 5897 and 5987 to verify correct reference
for issue in 5897 5987; do
echo -n "#$issue: "
curl -s https://api.github.com/repos/ChainSafe/forest/issues/"$issue" | grep -m1 '"title":' | sed -E 's/.*"title": "(.*)",/\1/'
doneLength of output: 106
Update misnumbered issue references in CHANGELOG.md
The link URLs point to issue 5987, but the text shows #5897. Change both entries (lines 44–49) to use #5987.
--- a/CHANGELOG.md
@@ lines 44-49
- [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets.
+ [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets.
- [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025).
+ [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [#6006](https://github.com/ChainSafe/forest/issues/6006) More strict checks for the address arguments in the `forest-cli` subcommands. | |
| - [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets. | |
| - [#5897](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025). | |
| - [#6006](https://github.com/ChainSafe/forest/issues/6006) More strict checks for the address arguments in the `forest-cli` subcommands. | |
| - [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for devnets. | |
| - [#5987](https://github.com/ChainSafe/forest/issues/5987) Added support for the NV27 _Golden Week_ network upgrade for calibration network. The upgrade epoch is set to `3_007_294` (Wed 10 Sep 23:00:00 UTC 2025). |
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 44 to 49, two entries currently display the wrong
issue number in the visible text as “#5897” while the link URLs point to issue
5987; update both visible references so they read “#5987” (making the displayed
issue number match the link target) and verify the rest of the line text remains
unchanged.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit