scripts/tests/calibnet_migration_regression_tests.sh (3)

10-10: Make command composition safer using an array (optional)

Using a string for a long command is brittle (word-splitting, future args with spaces). An array is safer.

Apply this diff for the definition:

- M I G R A T I O N _ T E S T ="$FOREST_PATH --chain calibnet --encrypt-keystore false --track-peak-rss --halt-after-import --height=-200 --no-gc --import-snapshot"
+ MIGRATION_TEST=( "$FOREST_PATH" --chain calibnet --encrypt-keystore false --track-peak-rss --halt-after-import --height=-200 --no-gc --import-snapshot )

Then invoke with:

# replace: $MIGRATION_TEST "URL"
"${MIGRATION_TEST[@]}" "URL"

---

10-10: Optional: gate the flag via env for local runs

If you want CI to always track RSS but keep local runs quiet, gate the flag via env without changing call sites.

Minimal change:

-MIGRATION_TEST="$FOREST_PATH --chain calibnet --encrypt-keystore false --track-peak-rss --halt-after-import --height=-200 --no-gc --import-snapshot"
+MIGRATION_TEST="$FOREST_PATH --chain calibnet --encrypt-keystore false ${TRACK_PEAK_RSS:+--track-peak-rss} --halt-after-import --height=-200 --no-gc --import-snapshot"

Usage:

• In CI: export TRACK_PEAK_RSS=1
• Locally (default): omit to skip the flag

---

10-10: Surface a one-line metric for CI consumption (nice-to-have)

Consider extracting and emitting a single “Peak RSS” line per run to aid trend tracking in job logs.

Example wrapper (no behavior change to the test result):

# After each invocation:
# ${MIGRATION_TEST[@]} "$URL" | tee /dev/stderr | rg -i 'Peak physical memory usage' || true

This keeps full logs while surfacing the metric.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: hanabi1224
PR: ChainSafe/forest#5930
File: build.rs:64-77
Timestamp: 2025-08-13T09:43:20.301Z
Learning: hanabi1224 prefers hard compile-time errors in build scripts rather than runtime safeguards or collision detection, believing it's better to fail fast and fix root causes of issues like malformed snapshot names.

scripts/tests/calibnet_db_migration.sh (3)

45-45: Stream time -v to a log file for later parsing (keeps console output too).

This makes peak RSS easy to grep from CI artifacts.

-/usr/bin/time -v forest --chain calibnet --log-dir "$LOG_DIRECTORY" --halt-after-import --config "${CONFIG_FILE}"
+/usr/bin/time -v forest --chain calibnet --log-dir "$LOG_DIRECTORY" --halt-after-import --config "${CONFIG_FILE}" 2> >(tee -a "$LOG_DIRECTORY/peak_rss_migration_import.log" >&2)

---

48-48: Do the same for the long-running sync phase.

Captures the backgrounded run’s peak RSS reliably in logs.

-/usr/bin/time -v forest --chain calibnet --log-dir "$LOG_DIRECTORY" --save-token ./admin_token --config "${CONFIG_FILE}" &
+/usr/bin/time -v forest --chain calibnet --log-dir "$LOG_DIRECTORY" --save-token ./admin_token --config "${CONFIG_FILE}" 2> >(tee -a "$LOG_DIRECTORY/peak_rss_migration_sync.log" >&2) &

---

45-48: Optional: add a fallback if /usr/bin/time is unavailable.

CI is Linux, but a small guard improves portability.

Example outside this hunk:

time_wrap() { if command -v /usr/bin/time >/dev/null; then /usr/bin/time -v "$@"; else "$@"; fi; }
# then replace: /usr/bin/time -v forest ...  =>  time_wrap forest ...

scripts/tests/harness.sh (1)

91-91: Capture time -v output to logs and keep console visibility.

Eases automated parsing of peak RSS from CI logs.

-  /usr/bin/time -v $FOREST_PATH --chain calibnet --encrypt-keystore false --log-dir "$LOG_DIRECTORY" &
+  /usr/bin/time -v "$FOREST_PATH" --chain calibnet --encrypt-keystore false --log-dir "$LOG_DIRECTORY" 2> >(tee -a "$LOG_DIRECTORY/peak_rss_node_run.log" >&2) &

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: hanabi1224
PR: ChainSafe/forest#5930
File: build.rs:64-77
Timestamp: 2025-08-13T09:43:20.301Z
Learning: hanabi1224 prefers hard compile-time errors in build scripts rather than runtime safeguards or collision detection, believing it's better to fail fast and fix root causes of issues like malformed snapshot names.

Learnt from: hanabi1224
PR: ChainSafe/forest#5867
File: src/ipld/util.rs:553-558
Timestamp: 2025-08-08T12:10:45.218Z
Learning: Forest project targets Rust stable >=1.89; features stabilized in 1.88 like let-chains are acceptable in this codebase.