feat: add support for power actor methods in `StateDecodeParams` API #5875

akaladarshi · 2025-07-29T12:28:23Z

Summary of changes

Changes introduced in this pull request:

Fixed a bug in other actors (each cid should only be registered for specific version)
Add power actor methods support
Added the test for the power actor methods (commented the MinerPowerExported since it's not present in the lotus)

Reference issue to close (if applicable)

Closes: #5715

Change checklist

I have performed a self-review of my own code,
I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
I have added tests that prove my fix is effective or that my feature works (if possible),
I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

New Features
- Added support for Lotus JSON serialization and deserialization of power actor parameters across multiple versions.
- Enabled registration and handling of power actor methods in the RPC registry for versions 8 through 16.
- Introduced version-based conditional registration for account, EVM, init, miner, and system actor methods.
Chores
- Updated internal module structure to include power actor support in relevant registries and modules.
- Improved code comments for clarity.
- Extended test coverage for power actor state decoding parameters.

coderabbitai · 2025-07-29T12:28:30Z

Walkthrough

Support for the Power actor state has been added to the Filecoin StateDecodeParams API. This includes new modules, Lotus JSON serialization/deserialization for Power actor method parameters across versions 8–16, method registration macros for each version, and integration into the actor registry. No existing logic was altered.

Changes

Cohort / File(s)	Change Summary
Power Actor Lotus JSON Serialization `src/lotus_json/actor_states/methods/power_actor.rs`	Introduces structs and trait implementations for Lotus JSON serialization/deserialization of Power actor method parameters across versions 8–16 using macros and custom helpers.
Power Actor Methods Module Registration `src/lotus_json/actor_states/methods/mod.rs`	Adds the `power_actor` module to the list of submodules.
Power Actor Registry Integration `src/rpc/registry/actors/mod.rs`, `src/rpc/registry/actors/power.rs`, `src/rpc/registry/methods_reg.rs`	Adds the Power actor to the registry, defines macros for registering methods by version, and updates the method registry to support the Power actor.
Versioned Actor Method Registration Refactoring `src/rpc/registry/actors/account.rs`, `src/rpc/registry/actors/evm.rs`, `src/rpc/registry/actors/init.rs`, `src/rpc/registry/actors/miner.rs`, `src/rpc/registry/actors/system.rs`	Refactors actor method registration functions to accept a version parameter and register methods only for the specified version using match statements.
API Decode Tests for Power Actor `src/tool/subcommands/api_cmd/api_compare_tests.rs`, `src/tool/subcommands/api_cmd/test_snapshots.txt`	Adds new test cases and snapshot entries for decoding Power actor method parameters for version 16 to the state decode params API tests.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant MethodRegistry
    participant PowerActorModule
    participant LotusJson

    Client->>MethodRegistry: Request decode for Power actor params (with version)
    MethodRegistry->>PowerActorModule: Lookup and register methods for version
    PowerActorModule->>LotusJson: Serialize/deserialize params (version-specific)
    LotusJson-->>PowerActorModule: Return Lotus JSON representation
    PowerActorModule-->>MethodRegistry: Register method handlers
    MethodRegistry-->>Client: Return decoded params

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Add support for the Power actor state in Filecoin.StateDecodeParams API (#5715)	✅
Compatibility with V8–V16 (#5715)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Suggested reviewers

LesnyRumcajs

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1862a32 and 226ff60.

📒 Files selected for processing (1)

src/rpc/registry/methods_reg.rs (7 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/rpc/registry/methods_reg.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: tests-release
GitHub Check: tests
GitHub Check: All lint checks
GitHub Check: Build forest binaries on Linux AMD64
GitHub Check: Build Ubuntu
GitHub Check: cargo-publish-dry-run
GitHub Check: Build MacOS
GitHub Check: Analyze (rust)
GitHub Check: Analyze (go)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch akaladarshi/add-power-actor-decode-params

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

akaladarshi · 2025-07-29T14:54:19Z

@coderabbitai full review

coderabbitai · 2025-07-29T14:54:26Z

✅ Actions performed

Full review triggered.

src/tool/subcommands/api_cmd/api_compare_tests.rs

LesnyRumcajs · 2025-08-01T14:19:46Z

no green checkmark!

akaladarshi force-pushed the akaladarshi/add-power-actor-decode-params branch from 2bfdc04 to d58f5b9 Compare July 29, 2025 12:29

akaladarshi added 3 commits July 31, 2025 13:25

bug: we were not registering methods with specific versions

7c3a509

feat: add support for power actor in state decode params API

ee120b7

linter changes

20cba40

akaladarshi force-pushed the akaladarshi/add-power-actor-decode-params branch from d58f5b9 to 20cba40 Compare July 31, 2025 08:05

akaladarshi added the RPC requires calibnet RPC checks to run on CI label Jul 31, 2025

akaladarshi added 3 commits July 31, 2025 13:38

small cleanup

c2b8700

test: add power actor method tests in api compare tests

588ed02

Merge branch 'main' into akaladarshi/add-power-actor-decode-params

738f1a1

akaladarshi marked this pull request as ready for review July 31, 2025 18:47

akaladarshi requested a review from a team as a code owner July 31, 2025 18:47

akaladarshi requested review from LesnyRumcajs and hanabi1224 and removed request for a team July 31, 2025 18:47

hanabi1224 reviewed Aug 1, 2025

View reviewed changes

src/tool/subcommands/api_cmd/api_compare_tests.rs Outdated Show resolved Hide resolved

hanabi1224 previously approved these changes Aug 1, 2025

View reviewed changes

Merge branch 'main' into akaladarshi/add-power-actor-decode-params

ab4b4b4

LesnyRumcajs reviewed Aug 1, 2025

View reviewed changes

src/tool/subcommands/api_cmd/api_compare_tests.rs Outdated Show resolved Hide resolved

address comments

1862a32

akaladarshi dismissed hanabi1224’s stale review via 1862a32 August 1, 2025 13:33

akaladarshi requested review from LesnyRumcajs and hanabi1224 August 1, 2025 13:33

Merge branch 'main' into akaladarshi/add-power-actor-decode-params

9510639

specify version in test to get correct cid

226ff60

akaladarshi enabled auto-merge August 1, 2025 15:41

LesnyRumcajs approved these changes Aug 1, 2025

View reviewed changes

hanabi1224 approved these changes Aug 1, 2025

View reviewed changes

akaladarshi added this pull request to the merge queue Aug 1, 2025

Merged via the queue into main with commit 8a6827c Aug 1, 2025
42 checks passed

akaladarshi deleted the akaladarshi/add-power-actor-decode-params branch August 1, 2025 16:29

coderabbitai bot mentioned this pull request Aug 18, 2025

feat: add support for verified reg actor in state decode params #5896

Merged

4 tasks

coderabbitai bot mentioned this pull request Aug 26, 2025

feat: add support for ethaccount actor in state decode params API #5995

Merged

4 tasks

coderabbitai bot mentioned this pull request Sep 4, 2025

chore: sort snapshot lists #6033

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add support for power actor methods in `StateDecodeParams` API #5875

feat: add support for power actor methods in `StateDecodeParams` API #5875

Uh oh!

akaladarshi commented Jul 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

akaladarshi commented Jul 29, 2025

Uh oh!

coderabbitai bot commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

LesnyRumcajs commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add support for power actor methods in StateDecodeParams API #5875

feat: add support for power actor methods in StateDecodeParams API #5875

Uh oh!

Conversation

akaladarshi commented Jul 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reference issue to close (if applicable)

Other information and links

Change checklist

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

akaladarshi commented Jul 29, 2025

Uh oh!

coderabbitai bot commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

LesnyRumcajs commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add support for power actor methods in `StateDecodeParams` API #5875

feat: add support for power actor methods in `StateDecodeParams` API #5875

akaladarshi commented Jul 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)