Skip to content

feat: add support for system actor in state decode params API #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akaladarshi merged 5 commits into from
Jul 29, 2025
Merged

feat: add support for system actor in state decode params API #5861

akaladarshi merged 5 commits into from
Jul 29, 2025

Conversation

@akaladarshi
Copy link
Collaborator

@akaladarshi akaladarshi commented Jul 23, 2025 •
edited by coderabbitai bot
Loading

Summary of changes

Changes introduced in this pull request:

  • Small refactor
  • Add System Actor method param support
  • Add support for empty param (this can be used by other actor methods whose methods doesn't accept any params)

Reference issue to close (if applicable)

Closes : #5726

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • New Features

    • Added support for the System actor, including registration of its methods across multiple versions.
    • System actor methods now correctly handle parameter deserialization, including empty input.

  • Bug Fixes

    • Improved deserialization to accept empty parameters for System actor methods.

  • Refactor

    • Removed redundant function for retrieving actor details, consolidating logic within the actor registry.

@akaladarshi akaladarshi requested a review from a team as a code owner July 23, 2025 15:43
@akaladarshi akaladarshi requested review from hanabi1224 and sudo-shashank and removed request for a team July 23, 2025 15:43
@akaladarshi akaladarshi added the RPC requires calibnet RPC checks to run on CI label Jul 23, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 23, 2025 •
edited
Loading

"""

Walkthrough

A new system module was added to the registry actors, providing registration for system actor methods across multiple versions. The method registration logic was updated to support the system actor, including macro enhancements for handling empty parameters. The redundant get_actor_type_from_code function was removed in favor of using the ActorRegistry method.

Changes

File(s) Change Summary
src/rpc/registry/actors/mod.rs Added pub(crate) mod system; to declare the new system module.
src/rpc/registry/actors/system.rs New file: Implements registration of system actor methods for multiple state versions.
src/rpc/registry/actors_reg.rs Removed the redundant get_actor_type_from_code function.
src/rpc/registry/methods_reg.rs Updated to support system actor: uses ActorRegistry, registers system methods, macro changes, and adds test for empty parameter deserialization.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant MethodRegistry
    participant ActorRegistry
    participant SystemActor

    Client->>MethodRegistry: register_known_methods()
    MethodRegistry->>ActorRegistry: get_actor_details_from_code(code_cid)
    ActorRegistry-->>MethodRegistry: (BuiltinActor, version)
    MethodRegistry->>SystemActor: register_actor_methods(registry, code_cid)
    SystemActor-->>MethodRegistry: Registers constructor methods for versions v8-v16
    MethodRegistry-->>Client: Registration complete
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes
"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9021d0b and f879b5c.

📒 Files selected for processing (1)
  • src/rpc/registry/methods_reg.rs (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/rpc/registry/methods_reg.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build MacOS
  • GitHub Check: Build Ubuntu
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: All lint checks
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch akaladarshi/add-system-actor-decode-params
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@akaladarshi akaladarshi added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 74892d1 Jul 29, 2025
36 checks passed
@akaladarshi akaladarshi deleted the akaladarshi/add-system-actor-decode-params branch July 29, 2025 08:23
This was referenced Aug 6, 2025
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Aug 18, 2025
Merged
4 tasks
This was referenced Aug 26, 2025
Merged
Merged
This was referenced Sep 2, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Sep 17, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@sudo-shashank sudo-shashank sudo-shashank approved these changes

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224 hanabi1224 is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for the System actor state in Filecoin.StateDecodeParams API

4 participants

@akaladarshi @LesnyRumcajs @sudo-shashank