Skip to content

chore: suppress RUSTSEC-2025-0046 #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LesnyRumcajs merged 1 commit into from
Jul 22, 2025
Merged

chore: suppress RUSTSEC-2025-0046 #5852

LesnyRumcajs merged 1 commit into from
Jul 22, 2025

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jul 22, 2025 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #5844
Closes #5850
Closes #5847
Closes #5845

Other information and links

Reported in filecoin-project/ref-fvm#2186

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated configuration to ignore a new security advisory.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner July 22, 2025 06:52
@LesnyRumcajs LesnyRumcajs requested review from elmattic and sudo-shashank and removed request for a team July 22, 2025 06:52
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2025 •
edited
Loading

Walkthrough

In the shadowed recesses of configuration, the deny.toml file has been altered to add the advisory ID "RUSTSEC-2025-0046" to the list of ignored advisories. This eldritch token pertains to a wasmtime issue, awaiting resolution in the cryptic depths of FVM. No other cosmic entities or logic flows have been disturbed.

Changes

File(s) Change Summary
deny.toml Added "RUSTSEC-2025-0046" to the ignored advisories, referencing an unresolved wasmtime anomaly.

Estimated code review effort

1 (~2 minutes) — A mere whisper in the void, requiring little mortal attention.

Suggested reviewers

  • akaladarshi
  • hanabi1224

Beware, for even the smallest configuration may awaken slumbering horrors beneath the surface, where the Elder Gods brood in silence.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
deny.toml (1)

8-8: Inscribe an expiry rune for this suppressed horror

By the pallid light of the gibbous moon we cast RUSTSEC-2025-0046 into the abyss, yet even the most potent wards of Yog-Sothoth must one day falter. Etch a dated TODO so future cultists remember to lift the seal once FVM drags in a patched Wasmtime, lest the forgotten menace linger forever.

-  "RUSTSEC-2025-0046", # wasmtime issue, this needs to be resolved in FVM
+  # TODO(✍ 2025-07-??): Remove once ref-fvm depends on a Wasmtime release that exorcises RUSTSEC-2025-0046
+  "RUSTSEC-2025-0046", # wasmtime issue, this needs to be resolved in FVM
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5aedfbd and 9841c81.

📒 Files selected for processing (1)
  • deny.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build Ubuntu
  • GitHub Check: All lint checks
  • GitHub Check: Build MacOS
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: tests
  • GitHub Check: tests-release

@LesnyRumcajs LesnyRumcajs enabled auto-merge July 22, 2025 06:56
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit f7dcceb Jul 22, 2025
36 checks passed
@LesnyRumcajs LesnyRumcajs deleted the bump-wasmtime branch July 22, 2025 12:41
@coderabbitai coderabbitai bot mentioned this pull request Oct 13, 2025
Merged
4 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 22, 2025
Merged
4 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 11, 2025
Merged
4 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 8, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@sudo-shashank sudo-shashank sudo-shashank approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@LesnyRumcajs @hanabi1224 @sudo-shashank