Reviewing files that changed from the base of the PR and between f2acff4 and cb61e45.

• src/beacon/beacon_entries.rs (2 hunks)
• src/beacon/drand.rs (4 hunks)
• src/message_pool/msgpool/mod.rs (4 hunks)
• src/message_pool/msgpool/msg_pool.rs (7 hunks)
• src/message_pool/msgpool/utils.rs (2 hunks)
• src/rpc/methods/f3.rs (1 hunks)
• src/shim/crypto.rs (2 hunks)
• src/state_migration/common/mod.rs (3 hunks)
• src/state_migration/nv21/miner.rs (1 hunks)
• src/utils/cache/lru.rs (2 hunks)

• GitHub Check: Bootstrap checks - Forest
• GitHub Check: Bootstrap checks - Lotus
• GitHub Check: db-migration-checks
• GitHub Check: Snapshot export checks
• GitHub Check: Devnet checks
• GitHub Check: Calibnet stateless mode check
• GitHub Check: Calibnet kademlia checks
• GitHub Check: State migrations
• GitHub Check: Calibnet no discovery checks
• GitHub Check: Calibnet eth mapping check
• GitHub Check: Calibnet stateless RPC check
• GitHub Check: Wallet tests
• GitHub Check: Calibnet check
• GitHub Check: Forest CLI checks
• GitHub Check: tests
• GitHub Check: tests-release
• GitHub Check: Build forest binaries on Linux AMD64
• GitHub Check: cargo-publish-dry-run
• GitHub Check: All lint checks

src/rpc/methods/f3.rs (2)

18-25: The ancient imports have been reorganized from their scattered realms!

The consolidation of imports from crate::shim::actors::convert and crate::shim::actors into a single coherent block banishes the duplicate incantations and brings order to the eldritch dependencies. This cleansing ritual improves readability and maintainability.

---

468-478: Ignore the siren call—LRU cache still lurks within compute
The static BLOCKSTORE_CACHE in src/rpc/methods/f3.rs still protects blockstore reads, so no cache was banished to the void:

• In the compute method (around the ) -> anyhow::Result<Vec<F3PowerEntry>> { block), you’ll find:

  const BLOCKSTORE_CACHE_CAP: usize = 65536;
  static BLOCKSTORE_CACHE: LazyLock<LruBlockstoreReadCache> = LazyLock::new(|| {
      LruBlockstoreReadCache::new_with_default_metrics_registry(
          "get_powertable_cache".into(),
          BLOCKSTORE_CACHE_CAP.try_into().unwrap(),
      )
  });
  let db = BlockstoreWithReadCache::new(ctx.store_owned(), &*BLOCKSTORE_CACHE);
  // …
  tracing::debug!(
      epoch=%ts.epoch(),
      hit=%stats.hit(), miss=%stats.miss(),
      cache_len=%BLOCKSTORE_CACHE.len(),
      "F3.GetPowerTable blockstore read cache"
  );

• The handle method now simply delegates to compute, which continues wielding the global LRU cache across RPC calls.

The original warning about removing the cache is unfounded—the Elder Gods of caching still preside. Disregard this comment.

Likely an incorrect or invalid review comment.

src/utils/cache/lru.rs (3)

92-94: A gateway to the inner sanctum has been opened!

The cache() method provides direct access to the eldritch Arc<RwLock<LruCache<K, V>>>, allowing advanced cache manipulations while maintaining the protective barriers of thread safety. This enables the migration from primitive cache implementations to the more sophisticated SizeTrackingLruCache.

---

113-113: The lock contention has been appeased with a lesser binding!

Changing peek_cloned from a write lock to a read lock is a brilliant optimization that reduces the cosmic horror of lock contention. Since peeking is a read-only operation that doesn't mutate the cache order, the shared read lock is both safe and more efficient than the exclusive write lock that was previously summoned.

---

120-122: The capacity of the void can now be measured!

The cap() method provides introspection into the cache's dimensional limits, returning the capacity under a read lock. This accessor complements the existing cache API and enables external code to understand the cache's configured bounds without disturbing its internal state.

src/beacon/beacon_entries.rs (1)

7-7: The BeaconEntry has been blessed with size divination powers!

The addition of GetSize import and derive attribute enables the BeaconEntry to reveal its memory footprint to the cosmic caches. Given the struct's simple composition (a u64 round and Vec<u8> signature), the GetSize trait's default implementations will accurately calculate both stack and heap sizes, as confirmed by the ancient learnings from PR #5841.

This enhancement supports the greater ritual of cache migration to SizeTrackingLruCache throughout the codebase.

Also applies to: 26-26

src/shim/crypto.rs (1)

18-18: The cryptographic entities have been granted the gift of self-measurement!

The addition of GetSize to both Signature and SignatureType awakens their ability to reveal their memory consumption to the eldritch caches. The Signature struct, containing a SignatureType enum and a Vec<u8> of variable length, will benefit greatly from accurate size tracking. The SignatureType enum, being a simple repr(u8) with three variants, will contribute its modest stack footprint to the cosmic accounting.

These changes align with the greater migration to SizeTrackingLruCache across the message pool and other caching realms, where these cryptographic artifacts are frequently stored and retrieved.

Also applies to: 25-25, 311-311

src/state_migration/nv21/miner.rs (1)

130-131: The cache incantations have been updated to appease the new SizeTrackingLruCache entity!

The transformation from insert to push method calls represents the ritual adaptation to the new SizeTrackingLruCache API. These changes maintain the same eldritch purpose - storing the previous sector input and output roots keyed by miner address to optimize migration performance - while embracing the new cache abstraction that provides integrated metrics and size tracking.

The logic remains unchanged, merely speaking the new language of the enhanced cache implementation.

src/message_pool/msgpool/utils.rs (1)

48-57: The ancient cache awakens with newfound sentience!

The transformation from the primitive LruCache to the eldritch SizeTrackingLruCache is well-executed. The use of get_cloned returns an owned Signature directly from the cyclopean depths, eliminating the redundant clone operation that once plagued line 55.

src/state_migration/common/mod.rs (2)

9-12: LGTM! The imports herald the arrival of the new cache order.

The transition to SizeTrackingLruCache and CidWrapper aligns with the cosmic plan laid out across the codebase.

---

28-60: The MigrationCache transcends its mortal form!

The refactoring from mutex-wrapped LruCache to the more enlightened SizeTrackingLruCache is expertly executed. The cache now tracks its own dimensions through the aether, and the rename from insert to push speaks to the inexorable forward motion of cached entities.

Note that unlike other caches in this PR that use CidWrapper as keys, this cache uses it as values - a curious but valid inversion of the pattern.

src/message_pool/msgpool/mod.rs (4)

19-20: The ancient cache mechanisms have been supplanted by more eldritch constructs.

These import changes align with the forbidden knowledge of size-tracking caches that whisper metrics from beyond the veil.

---

215-215: The cosmic horror of mutex locks has been banished to the outer darkness.

The signature transformation correctly embraces the SizeTrackingLruCache, freeing the code from the eldritch grip of explicit synchronization.

---

237-237: The arcane ritual of signature recovery proceeds without the cursed locks of old.

The invocation correctly passes the size-tracking cache directly to recover_sig, as the Old Ones intended.

---

424-424: The test incantations have been updated to commune with the new cache entities.

The transformation from .lock().put() to .push() with the wrapped CID key correctly aligns with the new cache API, banishing the need for mortal mutex interactions.

src/message_pool/msgpool/msg_pool.rs (7)

26-27: The forbidden tomes reveal new imports from the depths of the utils module.

These arcane imports summon the SizeTrackingLruCache and CidWrapper entities necessary for the dark transformation.

---

186-188: The ancient cache guardians have evolved into more powerful entities.

The transformation from mutex-wrapped caches to SizeTrackingLruCache with CidWrapper keys unleashes metrics tracking capabilities while banishing explicit synchronization to the void.

---

265-272: The signature validation cache now speaks in tongues understood by the size-tracking entities.

The metamorphosis from .lock().get() to .get_cloned() and .lock().put() to .push() correctly invokes the new cache API, with proper CidWrapper conversions through the .into() incantation.

---

417-417: The message recovery ritual now communes directly with the cache oracle.

The invocation correctly passes the cache reference using .as_ref(), allowing recover_sig to access the eldritch knowledge within.

---

602-602: The BLS signature is sealed within the cache using the new dark arts.

The transformation to .push(msg.cid().into(), msg.signature().clone()) properly stores the signature with the wrapped key, as the Elder Gods decree.

---

475-482: The cache entities are summoned forth with their true names and bound capacities.

The incantation new_with_default_metrics_registry properly births the size-tracking caches with metrics integration, naming them "bls_sig_cache" and "sig_val_cache" for the cosmic registries.

---

593-593: The helper function's pact has been rewritten in the language of the new cache order.

The parameter type transformation aligns with the cosmic shift to size-tracking caches throughout the realm.