fix: multiarch retag for docker images #5826
Conversation
WalkthroughThe GitHub Actions workflow for Docker image tagging was updated to use Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
4c5674b to
c7ae1d3
Compare
c7ae1d3 to
8b8c2b2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/docker-latest-tag.yml (2)
35-40: Trailing whitespace breaks YAML-lintLine 36 contains trailing spaces which are currently flagged by the CI linter:
- if: ${{ !fromJSON(github.event.inputs.dry_run) }}␠␠ + if: ${{ !fromJSON(github.event.inputs.dry_run) }}Remove the two stray spaces to satisfy YAMLlint.
35-44: Collapse duplicate commands & avoid copy-paste driftBoth the real and dry-run branches repeat two nearly identical
imagetools createcommands. The CLI supports multiple--tagflags, so the duplication can be removed:- docker buildx imagetools create --tag ghcr.io/chainsafe/forest:${{ github.event.inputs.new_tag }} ghcr.io/chainsafe/forest:${{ github.event.inputs.tag }} - docker buildx imagetools create --tag ghcr.io/chainsafe/forest:${{ github.event.inputs.new_tag }}-fat ghcr.io/chainsafe/forest:${{ github.event.inputs.tag }}-fat + docker buildx imagetools create \ + --tag ghcr.io/chainsafe/forest:${{ github.event.inputs.new_tag }} \ + --tag ghcr.io/chainsafe/forest:${{ github.event.inputs.new_tag }}-fat \ + ghcr.io/chainsafe/forest:${{ github.event.inputs.tag }} \ + ghcr.io/chainsafe/forest:${{ github.event.inputs.tag }}-fatRepeating the same block twice makes future edits error-prone; consolidating it keeps both branches in sync.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/docker-latest-tag.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/docker-latest-tag.yml
[error] 36-36: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: tests
- GitHub Check: tests-release
- GitHub Check: Calibnet kademlia checks
- GitHub Check: Calibnet no discovery checks
- GitHub Check: Calibnet eth mapping check
- GitHub Check: Bootstrap checks - Lotus
- GitHub Check: State migrations
- GitHub Check: Devnet checks
- GitHub Check: Snapshot export checks
- GitHub Check: Wallet tests
- GitHub Check: Forest CLI checks
- GitHub Check: Calibnet check
🔇 Additional comments (1)
.github/workflows/docker-latest-tag.yml (1)
26-26: Confirm runner label availability
runs-on: ubuntu-24.04-armis a non-standard label; GitHub-hosted runners currently exposeubuntu-latest,ubuntu-22.04, andubuntu-24.04(preview) but not an explicit ARM variant.
Unless you operate a self-hosted runner with that exact label this job will queue forever.Verify the label or switch to matrix strategy with
runs-on: ubuntu-24.04anddocker/setup-qemu-actionfor cross-platform support.
f7245f8 to
53944b4
Compare
Summary of changes
Changes introduced in this pull request:
v0.27.0tolatestand their-fatcounterparts.dry run: https://github.com/ChainSafe/forest/actions/runs/16194742981
push run which fixes the multiarch
latestand latest-fat`: https://github.com/ChainSafe/forest/actions/runs/16194760787/job/45718457911Before:
after
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit