feat: implement `Filecoin.ChainGetEvents` #5360

elmattic · 2025-02-27T16:35:48Z

Summary of changes

Changes introduced in this pull request:

Implement Filecoin.ChainGetEvents RPC method.
Add forest-tool index backfill subcommand.
Add a new column to support indices in the paritydb schema.

forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http forest_snapshot_calibnet_2025-04-01_height_2540376.forest.car.zst --filter ChainGetEvents -n 200
| RPC Method                    | Forest | Lotus |
|-------------------------------|--------|-------|
| Filecoin.ChainGetEvents (141) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4750

Change checklist

I have performed a self-review of my own code,
I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
I have added tests that prove my fix is effective or that my feature works (if possible),
I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

CLAassistant · 2025-03-24T13:37:38Z

All committers have signed the CLA.

hanabi1224 · 2025-04-11T12:35:56Z

api_compare-forest-rpc-ready is getting even slower, @elmattic could you please investigate?

2025-04-11T12:06:43.3323307Z  Container api_compare-forest-rpc-ready-1  Starting
2025-04-11T12:06:43.7631060Z  Container api_compare-forest-rpc-ready-1  Started
...
2025-04-11T12:16:33.3088763Z  Container api_compare-forest-rpc-ready-1  Exited

elmattic · 2025-04-11T12:49:55Z

api_compare-forest-rpc-ready is getting even slower, @elmattic could you please investigate?

2025-04-11T12:06:43.3323307Z  Container api_compare-forest-rpc-ready-1  Starting
2025-04-11T12:06:43.7631060Z  Container api_compare-forest-rpc-ready-1  Started
...
2025-04-11T12:16:33.3088763Z  Container api_compare-forest-rpc-ready-1  Exited

The eth_mapping background task will be removed entirely. See: #5567.

I suggest merging this PR first. What do you think @LesnyRumcajs ?

hanabi1224 · 2025-04-11T12:59:07Z

@elmattic could you disable indexer in RPC checks to make it fast and make sure it passes without the background indexer

elmattic · 2025-04-11T13:07:11Z

@elmattic could you disable indexer in RPC checks to make it fast and make sure it passes without the background indexer

The RPC tests will fail if the indexer is disabled.

hanabi1224 · 2025-04-11T13:08:35Z

scripts/tests/api_compare/docker-compose.yml

      - |
        set -euxo pipefail
-        # Perform basic initliazation, including generating the JWT token
+        # Perform basic initialization, including generating the JWT token


Let's set FOREST_CHAIN_INDEXER_ENABLED=0

src/daemon/db_util.rs

LesnyRumcajs · 2025-04-11T14:17:12Z

api_compare-forest-rpc-ready is getting even slower, @elmattic could you please investigate?
2025-04-11T12:06:43.3323307Z  Container api_compare-forest-rpc-ready-1  Starting
2025-04-11T12:06:43.7631060Z  Container api_compare-forest-rpc-ready-1  Started
...
2025-04-11T12:16:33.3088763Z  Container api_compare-forest-rpc-ready-1  Exited
The eth_mapping background task will be removed entirely. See: #5567.

I suggest merging this PR first. What do you think @LesnyRumcajs ?

If it degrades the CI performance significantly and there's no ready PR to fix this, I wouldn't merge it.

elmattic · 2025-04-11T14:21:28Z

api_compare-forest-rpc-ready is getting even slower, @elmattic could you please investigate?
2025-04-11T12:06:43.3323307Z  Container api_compare-forest-rpc-ready-1  Starting
2025-04-11T12:06:43.7631060Z  Container api_compare-forest-rpc-ready-1  Started
...
2025-04-11T12:16:33.3088763Z  Container api_compare-forest-rpc-ready-1  Exited
The eth_mapping background task will be removed entirely. See: #5567.
I suggest merging this PR first. What do you think @LesnyRumcajs ?
If it degrades the CI performance significantly and there's no ready PR to fix this, I wouldn't merge it.

I don't think this PR specifically degrades performance, it was already poor before, no? In any case, I've reduced the eth_mappings task to backfill only 300 epochs.

LesnyRumcajs · 2025-04-11T14:23:36Z

I don't think this PR specifically degrades performance, it was already poor before, no? In any case, I've reduced the eth_mappings task to backfill only 300 epochs.

Okay, from comment from @hanabi1224 I was under the impression that this PR made it slower. If it's not the case, then it's something for a completely different PR.

hanabi1224 · 2025-04-11T14:30:18Z

@LesnyRumcajs As discussed with @elmattic The performance issue has been temporarily mitigated by this commit, which will be removed with #5567

elmattic added 16 commits February 25, 2025 17:40

Add indexing task

af2eb8f

Rework configuration

31ff2b3

Enable forest indexer

8f59626

Merge branch 'main' into elmattic/optional-eth-mappings

ffb1b6f

Appease Clippy

66087f4

Enable fevm and fix lint error

359339a

Fix script

59b0472

Move ttl to retention epochs

1b8d677

Fix unit test

1dac532

Run collector only if eth_mappings is enabled

23276a4

Merge branch 'main' into elmattic/optional-eth-mappings

8f8969c

Remove eth_mapping_ttl from client config

1258c7f

Update documentation

f68709a

Update CHANGELOG

2fbe3da

Merge branch 'main' into elmattic/optional-eth-mappings

6fd9694

Add code to get events root cid

8b04076

elmattic changed the base branch from main to elmattic/optional-eth-mappings February 27, 2025 16:36

elmattic added 6 commits February 27, 2025 20:58

Implement method

382da80

Fix emitter id

394b1b9

Refactor to return a Vec

cc18a64

Fix events not matching events root cid

04dab6e

Add ChainGetEvents tests

dcb5a17

Add index subcommand

7df7b11

Base automatically changed from elmattic/optional-eth-mappings to main March 17, 2025 15:57

elmattic added 3 commits March 19, 2025 12:15

Add chain revalidation to api compare

29f69d8

Add missing impl

3726865

Fix incorrect path

ec909f8

elmattic force-pushed the elmattic/chain-get-events branch from 1a9ae89 to ec909f8 Compare March 24, 2025 13:48

Add sort policy

de7460c

github-actions bot deployed to preview April 11, 2025 11:57 View deployment

hanabi1224 mentioned this pull request Apr 11, 2025

fix(ci): run offline RPC checks in sequence to mitigate OOM issue #5569

Merged

4 tasks

hanabi1224 reviewed Apr 11, 2025

View reviewed changes

elmattic added 2 commits April 11, 2025 15:59

Avoid long running background task for eth_mappings

4e42049

Merge branch 'main' into elmattic/chain-get-events

9c6adc7

github-actions bot deployed to preview April 11, 2025 14:02 View deployment

hanabi1224 reviewed Apr 11, 2025

View reviewed changes

src/daemon/db_util.rs Outdated Show resolved Hide resolved

elmattic added 2 commits April 11, 2025 16:17

Apply Hailong suggestion

ac8751b

Add TODO comment

77ba2eb

hanabi1224 approved these changes Apr 11, 2025

View reviewed changes

github-actions bot deployed to preview April 11, 2025 14:19 View deployment

Reduce number of tipsets to check

c3b3e3b

github-actions bot deployed to preview April 11, 2025 14:27 View deployment

elmattic requested review from LesnyRumcajs and hanabi1224 April 11, 2025 15:26

LesnyRumcajs approved these changes Apr 11, 2025

View reviewed changes

elmattic added this pull request to the merge queue Apr 11, 2025

Merged via the queue into main with commit 98d31ba Apr 11, 2025
45 checks passed

elmattic deleted the elmattic/chain-get-events branch April 11, 2025 15:55

hanabi1224 mentioned this pull request Apr 11, 2025

fix(ci): transient error in F3GetCertificate #5574

Merged

4 tasks

feat: implement Filecoin.ChainGetEvents #5360

feat: implement Filecoin.ChainGetEvents #5360

Uh oh!

Conversation

elmattic commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reference issue to close (if applicable)

Other information and links

Change checklist

Uh oh!

CLAassistant commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hanabi1224 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elmattic commented Apr 11, 2025

Uh oh!

hanabi1224 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elmattic commented Apr 11, 2025

Uh oh!

hanabi1224 Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

elmattic Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LesnyRumcajs commented Apr 11, 2025

Uh oh!

elmattic commented Apr 11, 2025

Uh oh!

LesnyRumcajs commented Apr 11, 2025

Uh oh!

hanabi1224 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: implement `Filecoin.ChainGetEvents` #5360

feat: implement `Filecoin.ChainGetEvents` #5360

elmattic commented Feb 27, 2025 •

edited

Loading

CLAassistant commented Mar 24, 2025 •

edited

Loading

hanabi1224 commented Apr 11, 2025 •

edited

Loading

hanabi1224 commented Apr 11, 2025 •

edited

Loading

hanabi1224 commented Apr 11, 2025 •

edited

Loading