Address param should be optional in EthGetLogs API #6134
Description
Describe the bug
- Right now address parameter is required in
EthGetLogsAPI, It should be optional (as user can provide no address) - https://docs.metamask.io/services/reference/ethereum/json-rpc-methods/eth_getlogs
To reproduce
- Curl
EthGetLogswithout the address param
{"jsonrpc":"2.0","id":67,"method":"eth_getLogs","params":[{"blockHash":"0x501ef1118649467eba1aadaf5fba35c89a34dffb17395212bfb9b1fd29168fc2","topics":[["0x1c411e9a96e071241c2f21f7726b17ae89e3cab4c78be50e062b03a9fffbbad1"]]}]}
Log output
Log Output
{
"jsonrpc": "2.0",
"id": 67,
"error": {
"code": -32602,
"message": "JSON-RPC error:\n\tcode: -32602\n\tmessage: error deserializing parameter\n\tdata: {\"error\":\"missing field `address`\",\"index\":0,\"name\":\"ethFilter\",\"type\":\"forest::lotus_json::LotusJson<forest::rpc::methods::eth::types::EthFilterSpec>\"}\n"
}
}
Expected behaviour
No Error
Metadata
Metadata
Assignees
Labels
Type
Projects
Status