Skip to content

Reduce code duplication in vesting_funds.rs using macros #6050

@coderabbitai

Description

@coderabbitai

Description

The vesting_funds.rs file contains significant code duplication between V16 and V17 implementations that could be reduced through macro-ization.

Current State

  • VestingFundV16LotusJson and VestingFundV17LotusJson structs are nearly identical
  • HasLotusJson implementations for VestingFundV16 and VestingFundV17 are duplicated
  • VestingFundsV16LotusJson and VestingFundsV17LotusJson structs are nearly identical
  • HasLotusJson implementations for VestingFunds types are duplicated

Proposed Solution

Create macros to generate the common code patterns for different actor versions, reducing maintenance burden and potential for inconsistencies.

References

Requested by: @LesnyRumcajs

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions