Skip to content

Deprecate unordered graph traversal as it shows no perf gain #6013

@hanabi1224

Description

@hanabi1224

Summary

Completion Criteria

We should deprecate and remove unordered_stream_chain and unordered_stream_graph from the code base as it show no (even negative) perf gain on my laptop.

➜  snapshots forest-tool -V && forest-tool benchmark graph-traversal forest_snapshot_calibnet_2023-07-30_height_780000.forest.car.zst
forest-filecoin 0.29.0+git.0c00fb4c
  traversed 2.65 GiB at 65.20 MiB/s in 00:00:41                                                                         
➜  snapshots forest-tool -V && forest-tool benchmark graph-traversal forest_snapshot_calibnet_2023-07-30_height_780000.forest.car.zst
forest-filecoin 0.29.0+git.0c00fb4c
  traversed 2.65 GiB at 66.89 MiB/s in 00:00:40                                                                         
➜  snapshots forest-tool -V && forest-tool benchmark graph-traversal forest_snapshot_calibnet_2023-07-30_height_780000.forest.car.zst
forest-filecoin 0.29.0+git.0c00fb4c
  traversed 2.65 GiB at 66.89 MiB/s in 00:00:40                                                                        

➜  snapshots forest-tool -V && forest-tool benchmark unordered-graph-traversal forest_snapshot_calibnet_2023-07-30_height_780000.forest.car.zst
forest-filecoin 0.29.0+git.0c00fb4c
  traversed 2.65 GiB at 50.65 MiB/s in 00:00:53                                                                         
➜  snapshots forest-tool -V && forest-tool benchmark unordered-graph-traversal forest_snapshot_calibnet_2023-07-30_height_780000.forest.car.zst
forest-filecoin 0.29.0+git.0c00fb4c
  traversed 2.65 GiB at 48.71 MiB/s in 00:00:55                                                                         
➜  snapshots forest-tool -V && forest-tool benchmark unordered-graph-traversal forest_snapshot_calibnet_2023-07-30_height_780000.forest.car.zst
forest-filecoin 0.29.0+git.0c00fb4c
  traversed 2.65 GiB at 47.80 MiB/s in 00:00:56           
  • remove fn unordered_stream_chain and fn unordered_stream_graph

Additional Links & Resources

Metadata

Metadata

Assignees

Labels

Type: TaskDiscrete task to implement

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions