-
Notifications
You must be signed in to change notification settings - Fork 182
Closed
Labels
Type: BugSomething isn't workingSomething isn't working
Description
Describe the bug
We can create an unlimited number of filters using eth_newFilter. There should be a maximum cap on the number of filters that can be created, something like 100 or a bit fewer.
Each filter can potentially cause a performance hit in calls like eth_getFilterLogs, so we want to ensure that only a limited number can be created.
To reproduce
- Go to
api_run_testsand remove the call to ignore in the lastcreate_eth_new_filter_limit_testtest - Run
forest-tool api test-statefulwith similar parameters that are on the CI - See error
Expected behaviour
The test is passing, so we no longer need to call ignore on it.
Screenshots
Environment (please complete the following information):
- OS:
- Branch/commit
- Hardware
Other information and links
Metadata
Metadata
Assignees
Labels
Type: BugSomething isn't workingSomething isn't working
Type
Projects
Status
Done