Skip to content

eth_newFilter creation is not limited #5915

@elmattic

Description

@elmattic

Describe the bug

We can create an unlimited number of filters using eth_newFilter. There should be a maximum cap on the number of filters that can be created, something like 100 or a bit fewer.

Each filter can potentially cause a performance hit in calls like eth_getFilterLogs, so we want to ensure that only a limited number can be created.

To reproduce

  1. Go to api_run_tests and remove the call to ignore in the last create_eth_new_filter_limit_test test
  2. Run forest-tool api test-stateful with similar parameters that are on the CI
  3. See error

Expected behaviour

The test is passing, so we no longer need to call ignore on it.

Screenshots

Environment (please complete the following information):

  • OS:
  • Branch/commit
  • Hardware

Other information and links

Metadata

Metadata

Assignees

Labels

Type: BugSomething isn't working

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions