Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix: use params in InvokeSnap method#334

Merged
BeroBurny merged 1 commit intoChainSafe:masterfrom
casperholders:master
May 31, 2023
Merged

fix: use params in InvokeSnap method#334
BeroBurny merged 1 commit intoChainSafe:masterfrom
casperholders:master

Conversation

@KillianH
Copy link
Contributor

Short description of work done
Just added a line in the invokeSnap method to use params.

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

Now invokeSnap rpc calls use the params of the method.

Closes #333

@CLAassistant
Copy link

CLAassistant commented May 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Good work!


There is some issue with CI 😢 that does not make sense, after resolving will merge this

@BeroBurny BeroBurny added this pull request to the merge queue May 31, 2023
Merged via the queue into ChainSafe:master with commit 509e22b May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvokeSnap method doesn't use the params in the rpc request

4 participants