Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat: upgrade metamask version to 24#264

Merged
BeroBurny merged 12 commits intomasterfrom
lykhoyda/upgrade_metamask_version_to_24
Feb 3, 2023
Merged

feat: upgrade metamask version to 24#264
BeroBurny merged 12 commits intomasterfrom
lykhoyda/upgrade_metamask_version_to_24

Conversation

@Lykhoyda
Copy link
Contributor

@Lykhoyda Lykhoyda commented Feb 2, 2023

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

Closes #

@Lykhoyda Lykhoyda changed the title Lykhoyda/upgrade metamask version to 24 feat: upgrade metamask version to 24 Feb 2, 2023
@Lykhoyda Lykhoyda force-pushed the lykhoyda/upgrade_metamask_version_to_24 branch from 096a28f to e89124f Compare February 2, 2023 15:53
@Lykhoyda Lykhoyda marked this pull request as ready for review February 2, 2023 16:03
Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overa it looks good, left a few comments that I think will improve the overall quality.

Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good just needs a small refactor

@BeroBurny BeroBurny merged commit ee4a513 into master Feb 3, 2023
@BeroBurny BeroBurny deleted the lykhoyda/upgrade_metamask_version_to_24 branch February 3, 2023 16:21
@Lykhoyda Lykhoyda linked an issue Feb 6, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to MetaMask 10.24.X

2 participants