This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Merged
Conversation
BeroBurny
reviewed
Jan 12, 2023
Contributor
BeroBurny
left a comment
There was a problem hiding this comment.
I think that headless option can be "merged", I don't see the point of having it separated
Contributor
Author
I didn't get your idea. Do you mean making it a parameter outside the puppeteer and playwright configuration? As a generic for both? |
Contributor
yup |
e73dab5 to
b10e879
Compare
irubido
approved these changes
Jan 13, 2023
This was referenced Jan 16, 2023
This was referenced May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set headless version true as a default parameter
Short description of work done
PR Checklist
Changes
Issues
Closes #