Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix: dappeteer dependency#229

Merged
mpetrunic merged 1 commit intounstablefrom
lykhoyda/fix_dappeteer_dependency
Dec 15, 2022
Merged

fix: dappeteer dependency#229
mpetrunic merged 1 commit intounstablefrom
lykhoyda/fix_dappeteer_dependency

Conversation

@Lykhoyda
Copy link
Contributor

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

#228

Closes #

@Lykhoyda Lykhoyda changed the base branch from master to unstable December 15, 2022 15:55
BeroBurny
BeroBurny previously approved these changes Dec 15, 2022
Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeroBurny BeroBurny changed the base branch from unstable to master December 15, 2022 16:05
@BeroBurny BeroBurny dismissed their stale review December 15, 2022 16:05

The base branch was changed.

@BeroBurny BeroBurny changed the base branch from master to unstable December 15, 2022 16:05
@mpetrunic mpetrunic merged commit b76ca7c into unstable Dec 15, 2022
@mpetrunic mpetrunic deleted the lykhoyda/fix_dappeteer_dependency branch December 15, 2022 16:35
@mpetrunic
Copy link
Member

@Lykhoyda @BeroBurny why not directly to master?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done/Closed

Development

Successfully merging this pull request may close these issues.

3 participants