Skip to content

Reorder code in entity layer to have consistent order of properties.#7899

Merged
emackey merged 4 commits intomasterfrom
entityCleanup
Jun 11, 2019
Merged

Reorder code in entity layer to have consistent order of properties.#7899
emackey merged 4 commits intomasterfrom
entityCleanup

Conversation

@shunter
Copy link
Copy Markdown
Contributor

@shunter shunter commented Jun 3, 2019

Previously the list of properties for each type of Graphics in the entity layer was different everywhere. This made it quite difficult to compare the set of properties in the code vs the set of properties in CZML. I went through and reordered all these locations to have properties in the same order in each.

  • The documentation for the constructor for each graphics type
  • The content of the constructor (initializing _property and _propertySubscription to undefined)
  • The public get/set properties
  • The contents of the clone function for each graphics type
  • The contents of the merge function for each graphics type
  • The code assigning the values of properties in CzmlDataSource.

Also add some missing functionality to CzmlDataSource:

box.heightReference
cylinder.heightReference
ellipsoid.heightReference

corridor.classificationType
ellipse.classificationType
polygon.classificationType
polyline.classificationType
rectangle.classificationType

@cesium-concierge
Copy link
Copy Markdown

cesium-concierge commented Jun 3, 2019

Thanks for the pull request @shunter!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@shunter shunter force-pushed the entityCleanup branch 4 times, most recently from 9354248 to 2b4d9b3 Compare June 3, 2019 19:04
@emackey
Copy link
Copy Markdown
Contributor

emackey commented Jun 3, 2019

Merge conflict on CHANGES.md

@shunter shunter force-pushed the entityCleanup branch 2 times, most recently from 2484709 to 5f75445 Compare June 6, 2019 14:27
shunter added 2 commits June 11, 2019 15:58
Previously the list of properties for each type of Graphics in the entity layer was different everywhere.  This made it quite difficult to compare the set of properties in the code vs the set of properties in CZML. I went through and reordered all these locations to have properties in the same order in each.

* The documentation for the constructor for each graphics type
* The content of the constructor (initializing `_property` and `_propertySubscription` to `undefined`)
* The public get/set properties
* The contents of the `clone` function for each graphics type
* The contents of the `merge` function for each graphics type
* The code assigning the values of properties in `CzmlDataSource`.

Also add some missing functionality to `CzmlDataSource`:

`box.heightReference`
`cylinder.heightReference`
`ellipsoid.heightReference`

`corridor.classificationType`
`ellipse.classificationType`
`polygon.classificationType`
`polyline.classificationType`
`rectangle.classificationType`
@emackey emackey merged commit e7f31e7 into master Jun 11, 2019
@emackey emackey deleted the entityCleanup branch June 11, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants