Conversation
|
Thanks for the pull request @emackey!
Reviewers, don't forget to make sure that:
|
|
Here's a live demo. |
|
This is awesome! |
|
The scope of this PR has been dialed in a little. It's write-only (same as nodeTransformations) support for articulations at the model primitive level only. Ready for full review & merge. |
|
Any chance this can be merged in time for release? Scott doesn't know the contents of Model.js well enough to be comfortable merging this himself. We're confident in the articulations functionality, just need to make sure we're not breaking some conventions or established patterns in that file. |
|
I took a quick look at the |
|
|
|
@shunter Can you do the honors, or does this need additional reviewers? |
abwood
left a comment
There was a problem hiding this comment.
Looks good on my end once the Travis CI issue is adjudicated.
|
Thanks! Travis is a fluke, some unrelated test flaked out. |



This PR has initial support for 3D model articulations from the AGI_articulations vendor extension to glTF 2.0. There is no pointing vector or attach point support here, just articulations.
This isn't polished yet, but I'm opening it for early review from @shunter, @abwood, and @gbeatty.
TODO
There should be a better way to expose the available articulation names, stage name, min, max, and get/set current stage value.Let's push this until a more complete solution for 3D Model Entity API at a disadvantage #7831 is designed.Possibly in a separate PR, add support at the Entity layer.Also pushed.