[FEATURE] Προσθήκη λειτουργίας new_station#107
Merged
cerebrux merged 6 commits intoCerebruxCode:stablefrom Dec 27, 2020
Merged
Conversation
zoispag
approved these changes
Dec 5, 2020
Member
zoispag
left a comment
There was a problem hiding this comment.
LGTM! Δες 2 minor comments για consistency.
shelldio.sh
Outdated
| echo "https://mpv.io/installation/" | ||
| fi | ||
| } | ||
| new_station(){ |
Member
There was a problem hiding this comment.
Suggested change
| new_station(){ | |
| new_station() { |
Comment on lines
+231
to
+232
|
|
||
| done |
zoispag
requested changes
Dec 5, 2020
Member
zoispag
left a comment
There was a problem hiding this comment.
Sorry, μόλις παρατήρησα 2 ακόμα πραγματάκια.
shelldio.sh
Outdated
|
|
||
| -n, --new: Εμφανίζει την γενική λίστα με όλους τους διαθέσιμους ραδιοφωνικούς σταθμούς | ||
| και σας δίνει την δυνατότητα να προσθέσετε έναν νέο σταθμό στην λίστα με τους διαθέσιμους | ||
| ραδιοφωνικούς σταθμούς (στο αρχείο $all_stations) |
shelldio.sh
Outdated
| new_station(){ | ||
| echo "Εμφάνιση λίστας σταθμών" | ||
| sleep 1 | ||
| list_stations "$all_stations" |
Member
There was a problem hiding this comment.
Μήπως πρέπει να κάνουμε print τους αγαπημένους σταθμούς εδώ;
Author
There was a problem hiding this comment.
Τελικά να κάνω και αυτήν την αλλαγή;
f01d226 to
c988ceb
Compare
zoispag
reviewed
Dec 7, 2020
shelldio.sh
Outdated
| echo "https://mpv.io/installation/" | ||
| fi | ||
| } | ||
| new_station() { |
Member
There was a problem hiding this comment.
Suggested change
| new_station() { | |
| new_station () { |
For consistency
zoispag
reviewed
Dec 7, 2020
shelldio.sh
Outdated
| sleep 1 | ||
| clear | ||
| fi | ||
|
|
zoispag
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Προσθήκη λειτουργίας new_station η οποία προσθέτει έναν νέο σταθμό στο all_station.txt