Skip to content

fix for pv & pvc with multi-tenancy#937

Merged
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
pdgetrf:pv-pvc-fix
Jan 21, 2021
Merged

fix for pv & pvc with multi-tenancy#937
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
pdgetrf:pv-pvc-fix

Conversation

@pdgetrf
Copy link
Collaborator

@pdgetrf pdgetrf commented Jan 20, 2021 •
edited
Loading

Changes

Fix PVC issue due to missing multi-tenancy. Symptom is pvc going into LOST status unable to bound with PV.

Validation

  1. Arktos-up came up correctly
  2. Created and deleted the follow resources correctly
kubectl create tenant zeth
kubectl create -f /tmp/web.yaml --tenant zeth
kubectl create deployment nginx --image=nginx --tenant zeth
kubectl create -f vanilla.yaml --tenant zeth

kubectl create tenant apple
kubectl create -f /tmp/web.yaml --tenant apple
kubectl create deployment nginx --image=nginx --tenant apple
kubectl create -f vanilla.yaml --tenant apple

This bug also needs to have an e2e test. Due to the time constrain for scale-out release this will be added after scale-out kubelet poc migration is done. Tracking in #938

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Jan 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign xiaoningding
You can assign the PR to them by writing /assign @xiaoningding in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdgetrf pdgetrf mentioned this pull request Jan 20, 2021
Open
@pdgetrf pdgetrf requested a review from chenqianfzh January 20, 2021 18:51
@chenqianfzh
Copy link
Collaborator

chenqianfzh commented Jan 21, 2021

/lgtm

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Jan 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenqianfzh
To complete the pull request process, please assign xiaoningding
You can assign the PR to them by writing /assign @xiaoningding in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmn223
Copy link
Collaborator

zmn223 commented Jan 21, 2021

/approve

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Jan 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenqianfzh, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Jan 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenqianfzh, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit bcea52a into CentaurusInfra:master Jan 21, 2021
@XiaoningDing XiaoningDing mentioned this pull request Feb 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenqianfzh chenqianfzh chenqianfzh approved these changes

Assignees

@chenqianfzh chenqianfzh

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pdgetrf @centaurus-cloud-bot @chenqianfzh @zmn223