Agg watcher reduce usage pr#787
Conversation
|
/assign yb01 |
|
@Sindica: GitHub didn't allow me to assign the following users: yb01. Note that only centaurus-cloud members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…t back to watch.Interface)
…to watch.Interface)
| return false, 0 | ||
| } | ||
|
|
||
| err := aggWatchers.GetErrors() | ||
| switch err { |
There was a problem hiding this comment.
are the errors from the watcher and aggWatcher.GetErrors() match ?
There was a problem hiding this comment.
This is a revert back to previous implementation. Watch returns watch result and error if any. When I changed the return type of Watch interface, I have to aggregate the watch results and errors. Now the implementation of Watch function will decide how to return error. The auto generated client code calls GetErrors to return error.
…back to watch.Interface)
ae690d2 to
e523338
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sindica, yb01, zmn223 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perf run in https://github.com/futurewei-cloud/arktos-perftest/tree/perf-20201019
CI passed in #784
Compacted commits for easiler review