Skip to content

In get or create service function, get needs to happen before create.#1313

Merged
centaurus-cloud-bot merged 2 commits intoCentaurusInfra:masterfrom
Sindica:master-merge
Feb 2, 2022
Merged

In get or create service function, get needs to happen before create.#1313
centaurus-cloud-bot merged 2 commits intoCentaurusInfra:masterfrom
Sindica:master-merge

Conversation

@Sindica
Copy link
Collaborator

@Sindica Sindica commented Jan 27, 2022

Merge PR #1312 to master. This solve performance issue described in #1311

Copy link
Collaborator

@h-w-chen h-w-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Feb 2, 2022

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Feb 2, 2022

/approve

@centaurus-cloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: h-w-chen, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit 604985f into CentaurusInfra:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants