porting changes from community issue 77733 (#1151)#1173
Merged
centaurus-cloud-bot merged 6 commits intoCentaurusInfra:masterfrom Sep 17, 2021
Merged
porting changes from community issue 77733 (#1151)#1173centaurus-cloud-bot merged 6 commits intoCentaurusInfra:masterfrom
centaurus-cloud-bot merged 6 commits intoCentaurusInfra:masterfrom
Conversation
* Porting code from k8s https://github.com/kubernetes/kubernetes/pull/88962/files removing redundant code moving podInformer to node controller scope adding lock to node data map eviction processing refactor adding fakeGetPodsAssignedToNode adding pods to DeletePods parameters adding pods to MarkPodsNotReady parameters using pod pointers in node lifecycle controller MarkPodsNotReady retry fix adding test for retrying MarkPodsNotReady adding pods lister * fix for multiple TP logic in new ported code * minor fix and UT fix * more node controller UT fixes * more node controller UT fixes * fix ut failures and minor updates * optimize the case where the pods is empty on node for a TP Co-authored-by: Krzysztof Siedlecki <ksiedlecki@google.com>
Sindica
reviewed
Sep 9, 2021
Collaborator
Author
|
cherry-picked an dependent PR from scale-930 branch as well. removed do-not-merge flag. |
Sindica
reviewed
Sep 12, 2021
Sindica
reviewed
Sep 12, 2021
Sindica
reviewed
Sep 15, 2021
…he pod eviction flow to match with community code
Collaborator
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sindica, zmn223 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing redundant code
moving podInformer to node controller scope
adding lock to node data map
eviction processing refactor
adding fakeGetPodsAssignedToNode
adding pods to DeletePods parameters
adding pods to MarkPodsNotReady parameters
using pod pointers in node lifecycle controller
MarkPodsNotReady retry fix
adding test for retrying MarkPodsNotReady
adding pods lister
fix for multiple TP logic in new ported code
minor fix and UT fix
more node controller UT fixes
more node controller UT fixes
fix ut failures and minor updates
optimize the case where the pods is empty on node for a TP
Co-authored-by: Krzysztof Siedlecki ksiedlecki@google.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: