Skip to content

bump github.com/gorilla/websocket to v1.4.2#1127

Merged
centaurus-cloud-bot merged 2 commits intoCentaurusInfra:masterfrom
sonyafenge:fixissue1126
Aug 17, 2021
Merged

bump github.com/gorilla/websocket to v1.4.2#1127
centaurus-cloud-bot merged 2 commits intoCentaurusInfra:masterfrom
sonyafenge:fixissue1126

Conversation

@sonyafenge
Copy link
Collaborator

@sonyafenge sonyafenge commented Jul 28, 2021

Bump github.com/gorilla/websocket to v1.4.2 to fix integer overflow vulnerability

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1126

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


…ulnerability

go mod edit -replace github.com/gorilla/websocket=github.com/gorilla/websocket@v1.4.2
hack/update-vendor.sh
@sonyafenge sonyafenge changed the title fix issue #1126 bump github.com/gorilla/websocket to v1.4.2 Aug 2, 2021
@sonyafenge
Copy link
Collaborator Author

Scaleout run with 1tp1rp100 density run finished with success. you can find more log information under GCE_PROJECT=workload-controller-manager machine=sonyadev4:
/home/sonyali/logs/perf-test/gce-100/arktos/issue1126-080421-1x1x100/arktos

Copy link
Collaborator

@Sindica Sindica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Aug 17, 2021

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Aug 17, 2021

/approve

@centaurus-cloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sindica, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit 3bf7b03 into CentaurusInfra:master Aug 17, 2021
@sonyafenge sonyafenge deleted the fixissue1126 branch January 4, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arktos security alert

4 participants