Decouple proxy operations from kube-up and create-master functions and optimize proxy creation routines#1105
Merged
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom Jun 16, 2021
Conversation
h-w-chen
reviewed
Jun 15, 2021
h-w-chen
reviewed
Jun 15, 2021
h-w-chen
approved these changes
Jun 15, 2021
Collaborator
h-w-chen
left a comment
There was a problem hiding this comment.
lgtm
this change of proxy-up paves the way for faster infra setup. good job.
… Kubemark and kube-up and only create once at the end of clusters setup. start prometheus on proxy server machine remove uneeded checks
Collaborator
|
/lgtm |
Collaborator
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: h-w-chen, Sindica, zmn223 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Currently in Arktos scalability test setup, the proxy were created and then updated per RP or TP cluster creation, which is not efficient in setup the test env.
This PR decouples the proxy creation routines from the cluster master setup functions and only create the proxy once all RP/TPs were setup to optimize the proxy creation time for multiple RP/TP env.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
None