Skip to content

fix prometheus config to include haproxy metrics#1103

Merged
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
yb01:bugfix
Jun 8, 2021
Merged

fix prometheus config to include haproxy metrics#1103
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
yb01:bugfix

Conversation

@yb01
Copy link
Collaborator

@yb01 yb01 commented Jun 7, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

prometheus metric for the Arktos proxy is not picked up by the cluster api servers. this is a missing code in 330 code merged and fixed in 530 perf branch. Now merge the fix to master.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

Copy link
Collaborator

@Sindica Sindica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yb01 yb01 requested a review from zmn223 June 8, 2021 15:52
@zmn223
Copy link
Collaborator

zmn223 commented Jun 8, 2021

/lgtm

@zmn223
Copy link
Collaborator

zmn223 commented Jun 8, 2021

/approve

@centaurus-cloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sindica, zmn223

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot centaurus-cloud-bot merged commit d4ebf1e into CentaurusInfra:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants