Skip to content

Fix GC controller delete pod issue for multi-tenancy#1026

Merged
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
Sindica:multi-tenancy-gc-controller-fix
Mar 16, 2021
Merged

Fix GC controller delete pod issue for multi-tenancy#1026
centaurus-cloud-bot merged 1 commit intoCentaurusInfra:masterfrom
Sindica:multi-tenancy-gc-controller-fix

Conversation

@Sindica
Copy link
Collaborator

@Sindica Sindica commented Mar 13, 2021

Fix a issue found in #1020

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dingyin
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sindica Sindica force-pushed the multi-tenancy-gc-controller-fix branch from a696d49 to df7d095 Compare March 13, 2021 05:54
@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dingyin
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sindica Sindica force-pushed the multi-tenancy-gc-controller-fix branch from df7d095 to 13417a4 Compare March 15, 2021 17:12
@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 15, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dingyin
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sindica Sindica requested review from chenqianfzh and h-w-chen March 16, 2021 16:45
h-w-chen
h-w-chen approved these changes Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@h-w-chen h-w-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: h-w-chen
To complete the pull request process, please assign dingyin
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@h-w-chen h-w-chen removed their assignment Mar 16, 2021
@chenqianfzh
Copy link
Collaborator

chenqianfzh commented Mar 16, 2021

/lgtm

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenqianfzh, h-w-chen
To complete the pull request process, please assign dingyin
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sindica Sindica force-pushed the multi-tenancy-gc-controller-fix branch from 13417a4 to 203fdd7 Compare March 16, 2021 20:23
@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 16, 2021

New changes are detected. LGTM label has been removed.

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenqianfzh, h-w-chen
To complete the pull request process, please assign dingyin
You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XiaoningDing
Copy link
Collaborator

XiaoningDing commented Mar 16, 2021

/approve

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenqianfzh, h-w-chen, XiaoningDing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centaurus-cloud-bot
Copy link
Collaborator

centaurus-cloud-bot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenqianfzh, h-w-chen, XiaoningDing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XiaoningDing
Copy link
Collaborator

XiaoningDing commented Mar 16, 2021

/lgtm

@centaurus-cloud-bot centaurus-cloud-bot merged commit c1a3802 into CentaurusInfra:master Mar 16, 2021
@Sindica Sindica deleted the multi-tenancy-gc-controller-fix branch July 15, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-w-chen h-w-chen h-w-chen approved these changes

@chenqianfzh chenqianfzh chenqianfzh approved these changes

Assignees

@XiaoningDing XiaoningDing

@chenqianfzh chenqianfzh

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sindica @centaurus-cloud-bot @chenqianfzh @XiaoningDing @h-w-chen