You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR would not add any new features to the core code and only contains a notebook showing how to add dispersion to the CHGNet calculator through ASE. I installed pre-commit hooks and used them to format the code in the notebook.
I am not sure that DFT-D4 has a module available on pypi, you may need to use conda or mamba. Can you also install the python extension of DFT-D4? I think you will need conda install dftd4 dftd4-python -c conda-forge per the instructions here. I remember having a similar issue before when I installed the base dftd4 package without the dftd4-python component and tried to import DFT-D4. Without the python part, the import will fail.
Also, did you run pip install torch_dftd or pip install torch-dftd? I believe the latter is what is listed on pypi and I'm not sure the installation will work with an underscore.
I am not sure that DFT-D4 has a module available on pypi, you may need to use conda or mamba.
i see. not a fan of conda or mamba (strongly prefer uv). but that's not a PR blocker ofc, esp. for an optional dep. @BowenD-UCB you wanna try running the notebook? else happy to merge as is.
PS: pip install torch-dftd and pip install torch_dftd are equivalent.
I am not sure that DFT-D4 has a module available on pypi, you may need to use conda or mamba.
i see. not a fan of conda or mamba (strongly prefer uv). but that's not a blocker PR ofc, esp. for an optional dep. @BowenD-UCB you wanna try running the notebook? else happy to merge as is.
PS: pip install torch-dftd and pip install torch_dftd are equivalent.
I had not heard of uv before but I can understand the appeal, thank you for sharing! I like the idea of a rust-based environment manager.
Hi @ajhoffman1229 and @janosh
Thanks for the PR!
Sorry for the delay on this.
I tried to install these extra dependencies but encountered installation issue (package incompatibilities) with dftd4-python
As these are optional deps I'll merge as it is now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseAtomic simulation environmentdocsImprovements or additions to documentation
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
Checklist
This PR would not add any new features to the core code and only contains a notebook showing how to add dispersion to the CHGNet calculator through ASE. I installed pre-commit hooks and used them to format the code in the notebook.