Conversation
23d2be8 to
75590db
Compare
75590db to
e4fe16d
Compare
|
Will this be merged any time soon? |
|
@ikesyo do you have any idea of what is going on here with the CI? |
|
It's unfortunate that GitHub removed (without any prior notice) macOS 10.14 and Xcode 10.x from GitHub Actions' virtual environment: https://github.blog/changelog/2019-11-06-github-actions-macos-virtual-environment-updated-to-catalina. We switched the CI environment from Travis to GitHub Actions in #2884. We need to restore See also actions/runner-images#78. |
…oof 😖at the (without any prior notice) removal of macOS 10.14 and Xcode 10.x from GitHub Actions' virtual environment |
|
ive checked out this branch and built with make install but then MB000200:CL-Frameworks crissmyers$ carthage build --create-xcframework combined --no-use-binaries |
|
@bukira You're not using the carthage you just built. Probably you are using a version from |
|
Ok worked :-) can build xcframework how ever I cant build normal frameworks, I get no shared schemes, so have to reinstall main Carthage to do that,
However when I try to build an app on my iPhone with these xcframework I get
No code signature found.
Any ideas? Do I need to code signature the repos before I build xcframeworks ?
… On 9 Oct 2020, at 10:26, Tommaso Piazza ***@***.***> wrote:
@bukira <https://github.com/bukira> You're not using the carthage you just built. Probably you are using a version from brew. Run brew unlink carthage and make install again
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2881 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABXG66YDUIMTLPE7IA6ENTSJ3JKTANCNFSM4I26SVSA>.
|
I'll check that. Strange. I'll check code signature but off the top of my head that should be left to the consumer. That is the app that you are using the frameworks in. |
|
Yeah my code signing is fine in my app until I add the xcframeworks
I’m using the Xcode 12 compiler as well with ur branch build
… On 9 Oct 2020, at 17:03, Tommaso Piazza ***@***.***> wrote:
I cant build normal frameworks
I'll check that. Strange.
I'll check code signature but off the top of my head that should be left to the consumer. That is the app that you are using the frameworks in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
The iOS app install fine on the simulator just not device, with no code signature found
… On 9 Oct 2020, at 17:03, Tommaso Piazza ***@***.***> wrote:
I cant build normal frameworks
I'll check that. Strange.
I'll check code signature but off the top of my head that should be left to the consumer. That is the app that you are using the frameworks in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Ok, found the issue, I am using xcframework as .binaryTargets in a swift package, followed the apple doc on making binaryTargets for XCFrameworks in a swift package
targets: [
// Targets are the basic building blocks of a package. A target can define a module or a test suite.
// Targets can depend on other targets in this package, and on products in packages this package depends on.
.binaryTarget(
name: "AWSCore",
url: "myURL/AWSCore.xcframework.zip",
checksum: "a734a40f5c79dc71542e9903daf61efa5d46f43d16c7fc8f0540097845834d6b"
),
But I have to then link the frameworks manually from derived data, doesn’t seem right
The Binarys show in my “Referenced Binaries” in my swift package I link to but just by linking that swift package they don’t get “embedded and signed”
Cant find much info on how to link binaryTargets referenced in a swift package
… On 9 Oct 2020, at 17:08, Criss Myers ***@***.***> wrote:
The iOS app install fine on the simulator just not device, with no code signature found
> On 9 Oct 2020, at 17:03, Tommaso Piazza ***@***.***> wrote:
>
>
>
> I cant build normal frameworks
>
> I'll check that. Strange.
>
> I'll check code signature but off the top of my head that should be left to the consumer. That is the app that you are using the frameworks in.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <#2881 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABXG64RGOURRHJNOMG57MTSJ4X4HANCNFSM4I26SVSA>.
>
|
|
Seems to be a known issue with SPM and Xcode 12 embedding xcframeworks from binaryTargets and Xcode not signing them as it should
Work around is to force sign them in a script phase
… On 9 Oct 2020, at 17:06, Criss Myers ***@***.***> wrote:
Yeah my code signing is fine in my app until I add the xcframeworks
I’m using the Xcode 12 compiler as well with ur branch build
>> On 9 Oct 2020, at 17:03, Tommaso Piazza ***@***.***> wrote:
>>
>
> I cant build normal frameworks
>
> I'll check that. Strange.
>
> I'll check code signature but off the top of my head that should be left to the consumer. That is the app that you are using the frameworks in.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I'm also running into problems building normal frameworks as mentioned by @bukira. Output is like: Should we not be trying this out on Xcode 12? Perhaps I should try this on 11.7? |
If you want to checksum an xcframework you need Xcode 12 compiler I believe |
|
@tmspzz Thanks for the hard work on getting this feature in Carthage. The scenario I've tried is an .xcframework attached to a Github release or served via an https server. Here is the output for the current Carthage release(0.36) and the version from your branch: Official Carthage Release 0.36
Carthage build from this branch:
Although failing, the xcframework is present in the Carthage/Build/ios folder. Will these scenarios be covered by your PR? |
|
You can use SPM for binary downloads? That’s my plan and what I’m doing, make the xcframeworks with Carthage thanks to this great work , and package up in SPM .binaryTarget with a fix for Xcode 12 which i am yet to test with signing them
… On 10 Oct 2020, at 19:40, Tommaso Piazza ***@***.***> wrote:
As I mentioned a comment:
.version files don't work
binary downloads of xcframewroks don't work
They will be covered as some point. Probably not for the first release in the wild of this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Closing this since 0.37.0 with #3071 just shipped! |
No description provided.