Remove duplicates of the Protocol Ids#643
Merged
djeck1432 merged 2 commits intoCarmineOptions:masterfrom Jul 29, 2025
Merged
Conversation
Valera56pub
reviewed
Jul 26, 2025
Contributor
Valera56pub
left a comment
There was a problem hiding this comment.
Why is it imported not directly from the shared?
Why is it imported not directly from the shared.protocol_ids?
Contributor
|
LGTM |
Valera56pub
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes duplicate
ProtocolIDsdefinitions and declares it in the shared folder.Changes include:
ProtocolIDsdefinitions.ProtocolIDsto the correct structure.ProtocolIDsto the shared folder.Closes #636