Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Release 0.2.6 #11

Merged
adityatendulkar merged 10 commits into from
Jun 20, 2021
Merged

Release 0.2.6 #11

adityatendulkar merged 10 commits into from
Jun 20, 2021

Conversation

@adityatendulkar
Copy link
Member

@adityatendulkar adityatendulkar commented Jun 17, 2021

Changelog:

  • Bug fix for promotion
  • Bug fix for castling while in check

@adityatendulkar adityatendulkar added the release Releases a new version label Jun 17, 2021
@adityatendulkar adityatendulkar requested a review from Nixinova June 17, 2021 23:08
Nixinova
Nixinova previously requested changes Jun 17, 2021
View reviewed changes
Copy link
Member

@Nixinova Nixinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FenFurnace/src/validation.js

Line 159 in 6fdb497

if (colour === 'w') global.promotionPiece = global.promotionPiece.toUpperCase(); 

- if (colour === 'w') global.promotionPiece = global.promotionPiece.toUpperCase();
+ global.promotionPiece = global.promotionPiece[colour === 'w' ? toUpperCase : toLowerCase]();

@Nixinova Nixinova changed the title Version 0.2.6 Release 0.2.6 Jun 17, 2021
Nixinova
Nixinova reviewed Jun 18, 2021
View reviewed changes
@adityatendulkar adityatendulkar dismissed Nixinova’s stale review June 20, 2021 21:17

will be implemented

Nixinova
Nixinova reviewed Jun 20, 2021
View reviewed changes
@adityatendulkar adityatendulkar merged commit 408f7aa into main Jun 20, 2021
@Nixinova Nixinova deleted the version-0.2.6 branch June 20, 2021 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Nixinova Nixinova Nixinova left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release Releases a new version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityatendulkar @Nixinova