Skip to content

feat: only require screen capture and accessibility permissions#100

Merged
richiemcilroy merged 9 commits intoCapSoftware:mainfrom
r17x:main
Oct 7, 2024
Merged

feat: only require screen capture and accessibility permissions#100
richiemcilroy merged 9 commits intoCapSoftware:mainfrom
r17x:main

Conversation

@r17x
Copy link
Copy Markdown
Contributor

@r17x r17x commented Oct 5, 2024

Changes

  • Removed Audio (Microphone) Request permission on first-run.
  • Request permission when user click Audio (Microphone) Selection - (only show when not granted).

Attachments

Granted Not Granted
image image
image

/claim #91

Ready for review @richiemcilroy

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Oct 5, 2024

@r17x is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
Copy link
Copy Markdown
Member

Hey @r17x this is awesome! Thanks for submitting so quickly.

Would you be able to also do this for webcam as well?

Make it so that camera permission is not required at startup, until you decide to (by clicking the list).

Also, willing to add another $100 to the bounty if you can get the green MacBook webcam light to stop showing when no webcam is currently selected.

@r17x
Copy link
Copy Markdown
Contributor Author

r17x commented Oct 6, 2024

Already updated the PR @richiemcilroy

Here's videos for another $100 bounty.

WhatsApp.Video.2024-10-06.at.10.10.35.mp4

@r17x
Copy link
Copy Markdown
Contributor Author

r17x commented Oct 6, 2024

Heres for camera (same behavior with microphone). @richiemcilroy

permission.mp4

@richiemcilroy
Copy link
Copy Markdown
Member

Hey @r17x! looks awesome :)

One problem I've noticed is that once you do give permission, you only see the devices (webcam etc) once you right click and refresh.

Is there a way to make it so that we check again/refresh the list once the permission has been granted?

Also if it's possible to not open the dropdown list when we're actually requesting the permission.

So technically the entire "No Camera" button should request for permission on click, instead of just "Request Permission".

Actions:
1. Fix Device List Update: Automatically refresh the list of devices (webcam, etc.) once permission is granted, without requiring a manual right-click or refresh.
2. Prevent Dropdown from Opening During Permission Request: Ensure that the dropdown list for devices doesn’t open while the app is requesting camera permissions.
3. Update “No Camera” Button Behavior: Modify the “No Camera” button to request permission when clicked, instead of only the “Request Permission” button initiating the permission request.

@richiemcilroy
Copy link
Copy Markdown
Member

Let me know your thoughts @r17x whenever you get a chance - would love to get this live ASAP

@r17x
Copy link
Copy Markdown
Contributor Author

r17x commented Oct 7, 2024

@richiemcilroy Here's my new updates:

  1. Fix Device List Update: Automatically refresh the list of devices (webcam, etc.) once permission is granted, without requiring a manual right-click or refresh.

Automatically update the list options devices (you must be click the options lists for showing the list of devices). Anyway, I didn't understood what's you mean right-click or refresh.

  1. Prevent Dropdown from Opening During Permission Request: Ensure that the dropdown list for devices doesn’t open while the app is requesting camera permissions.

Fixed

  1. Update “No Camera” Button Behavior: Modify the “No Camera” button to request permission when clicked, instead of only the “Request Permission” button initiating the permission request.

Fixed

prs.mp4


export function createAudioDevicesQuery() {
const devices = createQuery(() => listAudioDevices);
createTimer(() => devices.refetch(), 1000, setInterval);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this and set using queryOptions -> refetchInterval: 1000 - same way

@richiemcilroy richiemcilroy merged commit 923d221 into CapSoftware:main Oct 7, 2024
@richiemcilroy
Copy link
Copy Markdown
Member

/tip @r17x $100

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Oct 8, 2024

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Oct 8, 2024

🎉🎈 @r17x has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants