Skip to content

docs: document incompatibility for Google Login on iOS#394

Merged
riderx merged 1 commit intomainfrom
feat-google-privacy-screen-doc-c1b57
Nov 29, 2025
Merged

docs: document incompatibility for Google Login on iOS#394
riderx merged 1 commit intomainfrom
feat-google-privacy-screen-doc-c1b57

Conversation

@WcaleNieWolny
Copy link
Copy Markdown
Contributor

@WcaleNieWolny WcaleNieWolny commented Nov 14, 2025

Update Google login documentation for iOS: added section on known problems and workaround for privacy screen plugin incompatibility

Summary by CodeRabbit

  • Documentation
    • Added documentation about Privacy Screen plugin compatibility with iOS Google Login, including a recommended workaround for users experiencing conflicts.

Update Google login documentation for iOS: added section on known problems and workaround for privacy screen plugin incompatibility
@riderx
Copy link
Copy Markdown
Member

riderx commented Nov 14, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

Identical "Known Problems" sections were added to the iOS Google Login documentation at two separate locations. Each section documents a Privacy Screen plugin incompatibility with Google Login and provides a workaround using PrivacyScreen.disable() before invoking SocialLogin.login, resulting in duplicate content in the guide.

Changes

Cohort / File(s) Summary
Documentation Updates
src/content/docs/docs/plugins/social-login/google/ios.mdx
Added duplicate "Known Problems" sections documenting Privacy Screen plugin incompatibility with Google Login, including workaround code snippet with PrivacyScreen.disable() at two insertion points

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify duplication intent: Confirm whether the identical "Known Problems" sections appearing at two locations is intentional or an accidental duplicate that should be removed or consolidated
  • Content accuracy: Validate that the workaround code snippet and compatibility notes are technically correct

Poem

🐰 Two notes, one doc, the same fine word,
A Privacy Screen warning now gently heard!
Disable before login, the fix is in place,
Though twice told, it guides with grace! 🪟✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main purpose of the changeset: documenting a known incompatibility between Google Login and a Privacy Screen plugin on iOS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-google-privacy-screen-doc-c1b57

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/content/docs/docs/plugins/social-login/google/ios.mdx (1)

246-248: Remove unnecessary blank lines.

Lines 247–248 contain two blank lines after the code block. Consider removing one to maintain consistent spacing with the rest of the document.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f06f58 and cb3f787.

⛔ Files ignored due to path filters (1)
  • .DS_Store is excluded by !**/.DS_Store
📒 Files selected for processing (1)
  • src/content/docs/docs/plugins/social-login/google/ios.mdx (1 hunks)
🔇 Additional comments (1)
src/content/docs/docs/plugins/social-login/google/ios.mdx (1)

228-245: Approve the Known Problems section with one caveat on duplication.

The documented Privacy Screen plugin incompatibility and workaround are clear, well-formatted, and technically sound. The code example correctly disables the privacy screen before invoking the login function.

However, the AI-generated summary mentions identical "Known Problems" sections were added at two separate locations, but the provided code shows only this one section. If duplicates exist elsewhere in the file, consolidate them to avoid confusing readers.

@riderx riderx merged commit bc8ce35 into main Nov 29, 2025
8 of 9 checks passed
@riderx riderx deleted the feat-google-privacy-screen-doc-c1b57 branch December 28, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants