Use text as dependency in remember for annotatedString#7
Merged
Calvin-LL merged 1 commit intoCalvin-LL:mainfrom Feb 3, 2025
Merged
Use text as dependency in remember for annotatedString#7Calvin-LL merged 1 commit intoCalvin-LL:mainfrom
text as dependency in remember for annotatedString#7Calvin-LL merged 1 commit intoCalvin-LL:mainfrom
Conversation
The `annotatedString` now depends on `text` in the `remember` function. This ensures that the annotated string is recomputed when the `text` changes, in addition to when `matches` changes.
Contributor
Author
|
I created the PR before I set up the issue. I am addressing a bug where recomposition does not work correctly in the following cases var clickCount by remember { mutableIntStateOf(0) }
val message = "Make this clickable, this too but not THIS. Click count: $clickCount."
// will recomposition when message changes
// Because it refer to clickCount in TextRules
Text(
AnnotatedString.rememberAutoLinkText(
text = message,
textRules = listOf(
TextRule.Clickable(
textMatcher = TextMatcher.StringMatcher("this"),
onClick = {
clickCount++
},
)
)
)
)
// no recomposition when message changes
Text(
AnnotatedString.rememberAutoLinkText(message)
) |
Owner
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
annotatedStringnow depends ontextin therememberfunction. This ensures that the annotated string is recomputed when thetextchanges, in addition to whenmatcheschanges.