Skip to content

Use text as dependency in remember for annotatedString#7

Merged
Calvin-LL merged 1 commit intoCalvin-LL:mainfrom
matsumo0922:make-recompoable
Feb 3, 2025
Merged

Use text as dependency in remember for annotatedString#7
Calvin-LL merged 1 commit intoCalvin-LL:mainfrom
matsumo0922:make-recompoable

Conversation

@matsumo0922
Copy link
Copy Markdown
Contributor

The annotatedString now depends on text in the remember function. This ensures that the annotated string is recomputed when the text changes, in addition to when matches changes.

The `annotatedString` now depends on `text` in the `remember` function. This ensures that the annotated string is recomputed when the `text` changes, in addition to when `matches` changes.
@matsumo0922
Copy link
Copy Markdown
Contributor Author

I created the PR before I set up the issue. I am addressing a bug where recomposition does not work correctly in the following cases

var clickCount by remember { mutableIntStateOf(0) }
val message = "Make this clickable, this too but not THIS. Click count: $clickCount."

// will recomposition when message changes
// Because it refer to clickCount in TextRules
Text(
    AnnotatedString.rememberAutoLinkText(
        text = message,
        textRules = listOf(
            TextRule.Clickable(
                textMatcher = TextMatcher.StringMatcher("this"),
                onClick = {
                    clickCount++
                },
            )
        )
    )
)

// no recomposition when message changes
Text(
    AnnotatedString.rememberAutoLinkText(message)
)

@Calvin-LL Calvin-LL merged commit 9a8157e into Calvin-LL:main Feb 3, 2025
@Calvin-LL
Copy link
Copy Markdown
Owner

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants