Skip to content

Improve compatibility with ping under FreeBSD#5869

Merged
TheWitness merged 4 commits intoCacti:1.2.xfrom
xmacan:fix_freebsd_ipv6
Oct 19, 2024
Merged

Improve compatibility with ping under FreeBSD#5869
TheWitness merged 4 commits intoCacti:1.2.xfrom
xmacan:fix_freebsd_ipv6

Conversation

@xmacan
Copy link
Copy Markdown
Member

@xmacan xmacan commented Oct 17, 2024

No description provided.

@TheWitness
Copy link
Copy Markdown
Member

TheWitness commented Oct 17, 2024

@xmacan you need to make a check for /sbin/ as on Standard Linux, ping6 is in /usr/sbin and it's not in the apache users path. Can you do that?

Copy link
Copy Markdown
Member

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must put a test to the ping6 location as in RH, Rocky, CentOS, Alma, it's in /usr/sbin/ and that path is not in Apache's path.

@TheWitness
Copy link
Copy Markdown
Member

ChangeLog too. ;)

@xmacan
Copy link
Copy Markdown
Member Author

xmacan commented Oct 18, 2024

My code is working. On freebsd is right location /sbin/ping6.

I see a different problem there. Check ping.php code on line 195 - there is test file_exists('/bin/ping6') but if condition is true, called is
/usr/sbin/ping6

Copy link
Copy Markdown
Member

@TheWitness TheWitness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a check for /sbin/ping6 as in Red Hat, Alma, CentOS, and Rocky, '/sbin' is NOT in the apache accounts path.

@TheWitness
Copy link
Copy Markdown
Member

Please check the updates. I'm merging this now.

@TheWitness TheWitness merged commit fbd80d2 into Cacti:1.2.x Oct 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2025
@netniV netniV changed the title fix freebsd ping path and parameters Improve compatibility with ping under FreeBSD Feb 2, 2025
@xmacan xmacan deleted the fix_freebsd_ipv6 branch July 8, 2025 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants