When storage units is blank, return correct response#5613
Merged
TheWitness merged 2 commits intoCacti:1.2.xfrom Dec 13, 2023
xmacan:fix_ss_host_disk
Merged
When storage units is blank, return correct response#5613TheWitness merged 2 commits intoCacti:1.2.xfrom xmacan:fix_ss_host_disk
TheWitness merged 2 commits intoCacti:1.2.xfrom
xmacan:fix_ss_host_disk
Conversation
TheWitness
approved these changes
Dec 13, 2023
Member
TheWitness
left a comment
There was a problem hiding this comment.
This requires repackaging the various templates using it
Member
Author
|
I'm busy. Maybe @bmfmancini ? |
Member
|
I can do it. @netniV what do you think? |
Member
|
What do I think of what? |
Member
|
Sorry I just saw this let me know if you want me to repackage
…On Thu, Dec 14, 2023, 07:21 Mark Brugnoli-Vinten ***@***.***> wrote:
What do I think of what?
—
Reply to this email directly, view it on GitHub
<#5613 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGEXTDYL4DDIOGRAP2UUBDYJLVLRAVCNFSM6AAAAABAS76QK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVG42TCNRUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@netniV , this change drives the repacking of maybe 6 packages. |
Member
|
If it's not critical it should wait |
Member
|
It's not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have few windows servers which stopped or never start working in cacti. It is disk utilization issue.
php ss_host_disk.php 'server_name' '961' '2:11165:1500:3:35:kaktus::::::' index
1
2
3
4
5
php ss_host_disk.php 'server_name' '961' '2:11165:1500:3:35:kaktus::::::' query used
1!4231188
2!0
3!193027394
4!27669
5!36638
php ss_host_disk.php 'server_name' '961' '2:11165:1500:3:35:kaktus::::::' query total
1!15547647
2!0
3!536866303
4!76784
5!65520
Get specific value is problem:
php ss_host_disk.php 'server_name' '961' '2:11165:1500:3:35:kaktus::::::' get total 4
U
php ss_host_disk.php 'server_name' '961' '2:11165:1500:3:35:kaktus::::::' get used 1
U
Problem is here:
var_dump($sau) = string(0) ""
var_dump($snmp_data) = string(8) "20881406"
So these few lines returns 'U'
if ($snmp_data != '' && $snmp_data < 0) {
return (abs($snmp_data) + 2147483647) * $sau;
} elseif (is_numeric($snmp_data) && is_numeric($sau)) {
return $snmp_data * $sau;
} else {
return 'U';
}