Extend length of maximum name in settings table#5442
Merged
netniV merged 3 commits intoCacti:1.2.xfrom Aug 11, 2023
xmacan:setting
Merged
Extend length of maximum name in settings table#5442netniV merged 3 commits intoCacti:1.2.xfrom xmacan:setting
netniV merged 3 commits intoCacti:1.2.xfrom
xmacan:setting
Conversation
netniV
requested changes
Aug 11, 2023
lib/functions.php
Outdated
| include_once($config['base_path'] . '/lib/poller.php'); | ||
|
|
||
| if (strlen($config_name) > 75) { | ||
| cacti_log("WARNING: Config option name '$config_name' is too long, will be truncated", false, 'SYSTEM'); |
Member
There was a problem hiding this comment.
This should be an error not a warning. It creates a problem that can't be fixed by the end user.
netniV
approved these changes
Aug 11, 2023
Member
|
Yes settings_user should also be extended to match to avoid issues. |
Member
Author
|
ok, I will do it |
Member
|
Update the audit schema in the docs folder. |
Member
|
Was the schema updated? |
Member
Author
|
My bad, I will fix it |
Member
|
I fixed it a few days ago. |
Member
|
Last weekend during my QA testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discusion:
Edit settings_user similarly?
value 75 hardcoded or add somewhere to include/files?