Add ability to periodically check RRDfiles for errors in batch#4943
Merged
TheWitness merged 3 commits intoCacti:1.2.xfrom Oct 7, 2022
xmacan:fix4639
Merged
Add ability to periodically check RRDfiles for errors in batch#4943TheWitness merged 3 commits intoCacti:1.2.xfrom xmacan:fix4639
TheWitness merged 3 commits intoCacti:1.2.xfrom
xmacan:fix4639
Conversation
Member
|
Very good work @xmacan. I'm impressed. The one PSR comment I would like to make is that you should remove the empty lines after the following loop/logic constructs: while
if/then/else
do
switchI'm normally doing this: $something = something _else;
// Always line here
if (something) {
// No extra lines here
so_something();
// No extra lines here
}
// Always extra line hereI hope you get the picture. If you can do those corrections, I think it's ready to merge. Changelog? I feel silly asking :) |
TheWitness
previously requested changes
Oct 6, 2022
Member
TheWitness
left a comment
There was a problem hiding this comment.
- CHANGELOG
- Remove extra whitespace as articulated in my first comment.
Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by @bmfmancini , thank you