Skip to content

Auth settings do not always properly reflect the options selected#4873

Merged
TheWitness merged 2 commits intoCacti:1.2.xfrom
ddb4github:authconfig
Jul 22, 2022
Merged

Auth settings do not always properly reflect the options selected#4873
TheWitness merged 2 commits intoCacti:1.2.xfrom
ddb4github:authconfig

Conversation

@ddb4github
Copy link
Copy Markdown
Contributor

@ddb4github ddb4github commented Jul 22, 2022 •
edited
Loading

Current incorrect behavior below:

  1. Collapse all section, reload page, Authentication Method field is hide
  2. Remove duplicate codeline about row_path_basic_mapfile
  3. Collapse "Special Users" section, switch Authentication Method and click General header, "Primary Admin" is hide
  4. Select Multiple LDAP/AD Domains, "LDAP General Settings" header is hide. User domain editor initial with ldap_server, ldap_port, and ldap_port_ssl, but they are hide

@ddb4github
Copy link
Copy Markdown
Contributor Author

ddb4github commented Jul 22, 2022

Another todo case about User Template:

  • User Template is not used by Multiple LDAP/AD Domains
  • Switch Authentication Method to Multiple LDAP/AD Domains, User Template will be hide
  • Click Special Users section header to expand, User Template will be show

Possible Solution:

  • Create a new JS function to override default click event of Special Users section header
  • Or change Special Users section collapsible is false

@TheWitness
Copy link
Copy Markdown
Member

TheWitness commented Jul 22, 2022

Jing, welcome back. Can you add a CHANGELOG entry?

@TheWitness TheWitness merged commit f8e0dfa into Cacti:1.2.x Jul 22, 2022
@ddb4github ddb4github deleted the authconfig branch July 22, 2022 16:14
@netniV netniV changed the title Correct auth settings fields hide/show Auth settings do not always properly reflect the options selected Aug 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddb4github @TheWitness