When creating RRD error image, font may not exist#4684
Merged
TheWitness merged 3 commits intoCacti:1.2.xfrom Apr 9, 2022
xmacan:fix_font_file
Merged
When creating RRD error image, font may not exist#4684TheWitness merged 3 commits intoCacti:1.2.xfrom xmacan:fix_font_file
TheWitness merged 3 commits intoCacti:1.2.xfrom
xmacan:fix_font_file
Conversation
netniV
requested changes
Apr 8, 2022
Member
netniV
left a comment
There was a problem hiding this comment.
Should be !empty and there's no change log for this ?
Member
Author
I haven't investigated why $dejavu_paths is empty or without Sans. |
Contributor
|
@xmacan Could u add one line for FreeBSD: diff --git a/include/global_arrays.php b/include/global_arrays.php
index 56bc6e033..e8506e4d0 100644
--- a/include/global_arrays.php
+++ b/include/global_arrays.php
@@ -2805,6 +2805,7 @@ if ($config['cacti_server_os'] == 'unix') {
'/usr/share/fonts/dejavu/', //RHEL/CentOS
'/usr/share/fonts/truetype/', //SLES
'/usr/share/fonts/truetype/dejavu/', //Ubuntu
+ '/usr/local/share/fonts/dejavu/', //FreeBSD
__DIR__ . '/fonts' //Build-in
);
} else { |
Member
|
@ddb4github, once confirmed, can you file a separate pull request? You can reference the original ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.