MIB Parser can sometimes cause errors in later PHP versions #4971
Description
Describe the bug
Debian is working on upgrading to php 8.2. Today, I received bug 1022229 in Debian about failing tests with that version of php.
To Reproduce
-
install php 8.2
-
Run the test suite
-
Notice the following (copied from here:
ERROR: Fail Unexpected output in /usr/share/cacti/site/log/cacti.log:
2022-10-17 12:40:41 - ERROR PHP DEPRECATED: Creation of dynamic property MibParser::$mib is deprecated in file: /usr/share/cacti/site/include/vendor/phpsnmp/mib_parser.php on line: 336
2022-10-17 12:40:41 - CMDPHP PHP ERROR Backtrace: (/utilities.php[98]:snmpagent_cache_rebuilt(), /lib/snmpagent.php[643]:snmpagent_cache_install(), /lib/snmpagent.php[611]:MibCache->install(), /lib/mib_cache.php[60]:MibParser->add_mib(), /include/vendor/phpsnmp/mib_parser.php[66]:MibParser->parse_mib(), /include/vendor/phpsnmp/mib_parser.php[336]:CactiErrorHandler())
2022-10-17 12:40:41 - ERROR PHP DEPRECATED: Creation of dynamic property MibParser::$mib is deprecated in file: /usr/share/cacti/site/include/vendor/phpsnmp/mib_parser.php on line: 336
2022-10-17 12:40:41 - CMDPHP PHP ERROR Backtrace: (/utilities.php[98]:snmpagent_cache_rebuilt(), /lib/snmpagent.php[643]:snmpagent_cache_install(), /lib/snmpagent.php[612]:MibCache->install(), /lib/mib_cache.php[60]:MibParser->add_mib(), /include/vendor/phpsnmp/mib_parser.php[66]:MibParser->parse_mib(), /include/vendor/phpsnmp/mib_parser.php[336]:CactiErrorHandler())
2022-10-17 12:40:41 - ERROR PHP DEPRECATED: Creation of dynamic property MibParser::$mib is deprecated in file: /usr/share/cacti/site/include/vendor/phpsnmp/mib_parser.php on line: 336
2022-10-17 12:40:41 - CMDPHP PHP ERROR Backtrace: (/utilities.php[98]:snmpagent_cache_rebuilt(), /lib/snmpagent.php[643]:snmpagent_cache_install(), /lib/snmpagent.php[613]:MibCache->install(), /lib/mib_cache.php[60]:MibParser->add_mib(), /include/vendor/phpsnmp/mib_parser.php[66]:MibParser->parse_mib(), /include/vendor/phpsnmp/mib_parser.php[336]:CactiErrorHandler())
Expected behavior
The test should pass. More importantly there shouldn't be deprecation warnings in the logs when running cacti.
Desktop (please complete the following information)
-
OS: Debian unstable with php-defaults from experimental
-
wget version 1.21.3-1+b2