Skip to content

SARIF 2.1#838

Merged
swissiety merged 7 commits intodevelopfrom
Sarif
Jun 18, 2025
Merged

SARIF 2.1#838
swissiety merged 7 commits intodevelopfrom
Sarif

Conversation

@Akshayaquinnox
Copy link
Contributor

@Akshayaquinnox Akshayaquinnox commented Apr 3, 2025

removing Error message
@Akshayaquinnox Akshayaquinnox requested a review from swissiety April 3, 2025 13:38
Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you determine that these changes are necessary (I could not find changed key names in the sarif 2.1 specification) ?

JSONObject tool = new JSONObject();
JSONObject driver = new JSONObject();

// TODO Put correct CryptoAnalysis version in report
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check: can we determine this here to implement that TODO?

@swissiety swissiety marked this pull request as ready for review June 17, 2025 10:21
@swissiety swissiety added this pull request to the merge queue Jun 18, 2025
Merged via the queue into develop with commit 3293a08 Jun 18, 2025
18 checks passed
@swissiety swissiety deleted the Sarif branch June 18, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants