Skip to content

Adding issue templates to Github #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spjuhel merged 6 commits into from
Apr 11, 2024
Merged

Adding issue templates to Github #867

spjuhel merged 6 commits into from
Apr 11, 2024

Conversation

@spjuhel
Copy link
Collaborator

@spjuhel spjuhel commented Apr 10, 2024 •
edited
Loading

Changes proposed in this PR:

  • Adding issue templates to the GitHub platform

PR Author Checklist

PR Reviewer Checklist

@spjuhel spjuhel requested review from chahank and peanutfun April 10, 2024 10:03
@spjuhel
Copy link
Collaborator Author

spjuhel commented Apr 10, 2024

The doc on this: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

It is also possible to create issue forms: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

@spjuhel spjuhel self-assigned this Apr 10, 2024
@spjuhel spjuhel changed the title Adding issue templates to Adding issue templates to Github Apr 10, 2024
peanutfun
peanutfun requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition, I highly welcome these templates! I have a few suggestions for improvement, see my comments.

@spjuhel @peanutfun
Apply suggestions from code review
3f766a8 
Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
chahank
chahank reviewed Apr 11, 2024
View reviewed changes
@chahank
Copy link
Member

chahank commented Apr 11, 2024

Fully agree! Thanks @spjuhel. I just proposed one small addition to help unexperienced users to find the information on their operating system and their Python version. Otherwise, I would propose to merge.

@spjuhel @chahank
Adding helpful comment on how to find python version
9e09866 
Co-authored-by: Chahan M. Kropf <chahan.kropf@usys.ethz.ch>
@spjuhel spjuhel merged commit 0b432a7 into main Apr 11, 2024
@emanuel-schmid emanuel-schmid deleted the feature/issues_templates branch April 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chahank chahank chahank left review comments

@peanutfun peanutfun peanutfun approved these changes

Assignees

@spjuhel spjuhel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spjuhel @chahank @peanutfun