update to xarray 2024.2 #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peanutfun
reviewed
Feb 20, 2024
|
|
||
| # Handle access errors | ||
| except (ValueError, TypeError) as err: | ||
| except (ValueError, TypeError, AttributeError) as err: |
Member
There was a problem hiding this comment.
This is correct and expected. From the v2024.2 changelog:
DataArray.dt now raises an AttributeError rather than a TypeError when the data isn’t datetime-like.
Thanks for the fix!
peanutfun
approved these changes
Feb 20, 2024
tovogt
approved these changes
Feb 21, 2024
Collaborator
tovogt
left a comment
There was a problem hiding this comment.
The PR looks fine to me, in general. However, the fact that version 2024.2 slows down the unit test by a factor 4 is quite suspicious. I would suggest to merge this, but to create a separate issue that makes note of the slowdown. I would suspect that it's possible to avoid the slowdown somehow, but I don't have time to investigate this any further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
year_month_day_accessorofHazard.from_xarray_rasterwhere: thearrayargument is not reallly a date-time array. This PR fixes the problem by simply adding the Exception type to the list of caught Exceptions.test_base_xarray.TestReadDefaultNetCDF.test_event_no_timetook between 6 and 8 seconds where it finished in 1 to 2 seconds with version 2024.1This PR fixes #852
PR Author Checklist
develop)PR Reviewer Checklist