add impact.select reset_frequency option #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@emanuel-schmid All tests are failing due to missing internet connection. Is this a temporary issue or do I need to change something? |
Member
|
@timschmi95 An issue with the data API firewall. Will probably take until next week to be resolved |
Collaborator
|
may still fail due to a problem with the installation environment but at least the firewall issue is solved |
peanutfun
requested changes
Jan 30, 2024
Member
peanutfun
left a comment
There was a problem hiding this comment.
Thanks a lot for this nice contribution! 🙌 I have a few minor suggestions.
peanutfun
approved these changes
Jan 30, 2024
Member
peanutfun
left a comment
There was a problem hiding this comment.
Excellent work, @timschmi95 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #830
PR Author Checklist
develop)PR Reviewer Checklist