This PR fixes #819 in sample_from_poisson, which causes Climada to fail if lam = 1
#820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lam = 1sample_from_poisson, which causes Climada to fail if lam = 1
Collaborator
|
The longer I think about it the more I get confused. Why this case distinction? |
Collaborator
|
The only reason I can think of is to make the yearset module applicable for hazards that are provided on an annual basis (like the ISIMIP ones), although I agree that it is not particularly useful or needed at all. So removing it would be fine for me. |
Collaborator
|
@carmensteinmann thanks! I've created another PR #823 (I didn't want to edit this one as it comes from a forged repository) |
Collaborator
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#819
This PR fixes #819
PR Author Checklist
develop)PR Reviewer Checklist